1729825 - Email address is not auto-filled on aliexpress.com

Status: RESOLVED FIXED

(Toolkit :: Password Manager: Site Compatibility, defect, P1)

Description

[Ksenia Berezina [:ksenia]]

Attachment: 131986533-441bd0fa-aa76-4023-b86b-366bb8b6ef24.png

This was reported in https://github.com/webcompat/web-bugs/issues/85600

To reproduce:

1. Open https://www.aliexpress.com/, hover on "Account" menu element and click on "Sign in" (or Register to create an account)
2. Once prompted, save email and password
3. Click on "Sign out" under the "Account", which should redirect back to the main page
4. Attempt to login again

Expected:
Email is prefilled

Actual:
Email field is empty

This appears to be a regression:

Was this integration build good, bad, or broken? (type 'good', 'bad', 'skip', 'retry', 'back' or 'exit' and press Enter): good
240:58.82 INFO: Narrowed integration regression window from [4c48537b, 71ef95dc] (3 builds) to [5494e55d, 71ef95dc] (2 builds) (~1 steps left)
240:58.82 INFO: No more integration revisions, bisection finished.
240:58.82 INFO: Last good revision: 5494e55dcb1b8da26f5cf83a6fd78be22381e22a
240:58.82 INFO: First bad revision: 71ef95dc36a89dd2563c570b36eb7e94ffede541
240:58.82 INFO: Pushlog:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=5494e55dcb1b8da26f5cf83a6fd78be22381e22a&tochange=71ef95dc36a89dd2563c570b36eb7e94ffede541

Comment 1

[Ksenia Berezina [:ksenia]]

Hi Dimi, could you please take a look?

Comment 2

[Dimi Lee [:dimi]]

In Bug 1690865, we look for username/email keyword in a form to locate the username field instead of just using the previous <input> of the password field.
In www.aliexpress.com, the password field doesn't have an associated form, so we use the "rootElement" of the password field as its "form" (so it is the root docuemnt in this case). However, the document also has another invisible field with an email keyword, so the username searching algorithm picks the invisible field as the username field.

The markup of the invisible field:

<input class="alert-subscribe-input" data-role="input" placeholder="Please enter your email" type="text">

I guess the right solution for this bug is not filling data to an invisible field. Although I think this is something we should do, we hesitated to do it because visibility check is expensive. In Bug 1681985, I see the opportunity to have a faster visibility check, I'll do more test to compare the performance between :dthayer's c++ IsVisible implementation and js implementation (ex. IsVisible in fathom).

If we think we should deal with this issue ASAP, then I'll suggest we use site recipe to workaround first.

Comment 3

[Tim Giles [:tgiles]]

Changing severity to S3 because the website is still able to be used.

Comment 4

[Dimi Lee [:dimi]]

This is fixed after adding aliexpress to site recipe.