1729847 - pocket dialog closes unintentionally

Status: REOPENED

(Firefox :: Pocket, defect)

Description

[tom]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:93.0) Gecko/20100101 Firefox/93.0

Steps to reproduce:

hi.

am using the pocket extension regularly to help me remember things. whenever i tag a bookmark, the dialog behind the browser_action button behaves weird compared to other browser platforms.

Actual results:

1. click pocket button, dialog opens
2. annoyance #1: 'Saving' and spinning wheel show up forever, while on safari it's a snap
3. annoyance #2: tags input field is not focused, making it necessary to click before typing
4. start typing tag names
5. annoyance #3: selecting a tag from the dropdown list followed by ENTER closes the dropdown immediately

Expected results:

2. be responsive
3. focus tags input field
4. close dialog on ENTER ONLY IF user isn't in the process of selecting a tag

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Firefox::Pocket' component, and is moving the bug to that component. Please revert this change in case you think the bot is wrong.

Comment 2

[Andrei Purice]

Marking this enhancement as NEW in order for it to gain visibility.

Comment 3

[Scott [:thecount] Downe]

Annoyance 1 is good feedback. It should only take a second or 2, if it takes longer, it feels like a bug.
Annoyance 2 is known and is likely to be added in the next round of changes to the Pocket panel, we have not yet committed to when that round happens, but an overhaul of the tag feature has been considered.
Annoyance 3 looks like a bug. I can reproduce what you're seeing using FIrefox nightly, but a local build with a new profile works as expected. I'll dig into this issue and see what's up.

Comment 4

[Scott [:thecount] Downe]

I've traced annoyance 3 down to Bug 1693582, which makes sense.

Once thing that doesn't add up is in your initial comment it says the issue is happening in ff 93, but the bug I traced to causing the issue landed in 94.

Comment 5

[Scott [:thecount] Downe]

Attachment: Bug 1729847 - Fixing Pocket panel auto closing on enter

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a5bf87dffba3
Fixing Pocket panel auto closing on enter r=mconley

Comment 7

[tom]

(In reply to Scott [:thecount] Downe from comment #4)

I've traced annoyance 3 down to Bug 1693582, which makes sense.

Once thing that doesn't add up is in your initial comment it says the issue is happening in ff 93, but the bug I traced to causing the issue landed in 94.

wow, great progress, thanks.

for ff94: sounds strange to me because i'm observing this issue since the ff80s – am using dev edition for ages now.

Comment 8

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/a5bf87dffba3

Comment 9

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1693582

Comment 10

[Scott [:thecount] Downe]

(In reply to tom from comment #7)

(In reply to Scott [:thecount] Downe from comment #4)

I've traced annoyance 3 down to Bug 1693582, which makes sense.

Once thing that doesn't add up is in your initial comment it says the issue is happening in ff 93, but the bug I traced to causing the issue landed in 94.

wow, great progress, thanks.

for ff94: sounds strange to me because i'm observing this issue since the ff80s – am using dev edition for ages now.

That's interesting.

Well, the fix I landed was a fairly generic catch all for this, so might also fix the issue you're experiencing, but I'm confident given the timeline you're experiencing something different than what I used to verify my fix.

So I think we should keep an eye on this if possible and when dev edition updates to 94 (I am not sure on the timing for dev edition releases), feel free to let me know if the issue is fixed for you or not. (Knowing you're using dev edition, I'll give that a go too).

Comment 11

[tom]

@scott i am still seeing the issue with 94.0b6. select first tag - ENTER - popup closes.
i have a bunch of extensions installed, but i doubt they have an influence...

Comment 12

[Scott [:thecount] Downe]

I just tried this on dev edition 94.0b8, which seems to be the most recent dev edition. A bit newer than the one you have.

Created a new profile, I couldn't reproduce the issue.

I agree it's unlikely it's an extension, but it does seem like it's something set in your profile, which could include extensions.

Things we can try to rule out as possibly related.

1. worth updating to 0b8.
2. is probably worth ruling out extensions anyway, just to be sure, by disabling each extension and checking.
3. worth creating a new profile and checking that it does or does not have the issue. I suspect a new profile fixes it, and it's something up with your older profile. It's also worth keeping your old profile around, for debugging purposes, to get to the bottom of this. Also probably don't want to drop everything and move to a new profile, that's super disruptive. If you need it here is help on creating and switching between profiles https://support.mozilla.org/en-US/kb/profile-manager-create-remove-switch-firefox-profiles

I would be very curious to get to the bottom of this, but these types of bugs tend to be tricky. Thanks for your patience.

Comment 13

[tom]

1. ok, updated to b8
2. see 3.
3. ok, fresh profile

still, selecting a tag + ENTER closes dialog.

Comment 14

[Scott [:thecount] Downe]

It's surprising a new profile doesn't fix it.

I don't think it's specific to dev edition anymore, but something else to do with your setup that's somewhat unique to you, somehow. Locale or region maybe? Something specific with your Pocket account? Premium or regular account? Private browsing maybe? Maybe some tags in your account are bugged somehow?

Doesn't really make sense though.

I'm going to pull in Andrei Vaida and Rares Bologa to see if they can help varify this, and hopefully get something reproducible, as per the instructions here https://mana.mozilla.org/wiki/pages/viewpage.action?spaceKey=PI&title=PI+Request

Steps to try to verify:

1. Log into Pocket
2. Go to a page to save to Pocket
3. Click the save to Pocket button.
4. Start typing a tag from the tag dropdown, highlight it by clicking the arrow keys, and select it with enter.

Expected: Should save the tag, and display a "Tags Added" dialog.
Actual: Panel immediately closes.

Thanks

Comment 15

[Marius Coman [:mcoman], Ecosystem QA - PTO until 8th of November, for any requests ping :cmuresan]

Hi, Scott! Unfortunately, I have not managed to reproduce the issue using the steps from the above comment.
In order to try to reproduce the issue, I’ve used a regular Pocket account and a premium one, however, the tags were successfully saved each time without dismissing the "Saved to Pocket" doorhanger.

Tested on Windows 10 x64, macOS 11.6, and macOS 10.15 using the latest Firefox Beta 94.0 (Build ID - 20211025220926) and the latest Firefox Developer Edition 94.0b9 (Build ID - 20211021185848).

@tom, in order to identify if the issue is caused by the browser or by the Pocket account, could you please create a new pocket account, create some tags in order to trigger the suggestions in the doorhanger, and see if you still reproduce the issue?

Thanks!

Comment 16

[BugBot [:suhaib / :marco/ :calixte]]

Redirect a needinfo that is pending on an inactive user to the triage owner.
:thecount, since the bug doesn't have a severity set, could you please set the severity or close the bug?

For more information, please visit auto_nag documentation.