1729860 - Remove the MIPS32 backend

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, task, P3)

Description

[Jan de Mooij [:jandem]]

See bug 1728973. As Lars noted there, the MIPS32 backend has been broken for a long time and the maintainers are only working on MIPS64.

Comment 1

[Lars T Hansen [:lth]]

I started looking at this as a background activity but I think we should hold off until the LoongArch64 port has landed, to create minimal turbulence for that patch.

Comment 2

[André Bargull [:anba]]

Attachment: Bug 1729860 - Part 1: Remove mips32 from configure. r=#spidermonkey-reviewers!

Remove jit and simulator support for mips32.

Comment 3

[André Bargull [:anba]]

Attachment: Bug 1729860 - Part 2: Remove ifdef code for mips32. r=#spidermonkey-reviewers!

• Remove code guarded by JS_CODEGEN_MIPS32 or JS_SIMULATOR_MIPS32.
• Remove mips32 specific code in "js/src/jit/mips-shared".

Comment 4

[André Bargull [:anba]]

Attachment: Bug 1729860 - Part 3: Remove mips32 MacroAssembler definitions. r=#spidermonkey-reviewers!

The change to "config/check_macroassembler_style.py" will be reverted in part 5.
It's only needed temporarily to ensure the python script doesn't report errors
while the mips32 source files are still present.

Comment 5

[André Bargull [:anba]]

Attachment: Bug 1729860 - Part 4: Remove mips32 source files. r=#spidermonkey-reviewers!

Comment 6

[André Bargull [:anba]]

Attachment: Bug 1729860 - Part 5: Simplify MacroAssembler architecture definitions. r=#spidermonkey-reviewers!

Replace mips_shared with mips64 and simplify DEFINED_ON to use
PER_SHARED_ARCH or PER_ARCH when possible. (This requires to add wasm32
stubs in some cases.)

Comment 7

[André Bargull [:anba]]

Attachment: Bug 1729860 - Part 6: Remove MIPS32 specific code from mips-shared. r=#spidermonkey-reviewers!

Comment 8

[André Bargull [:anba]]

Attachment: Bug 1729860 - Part 7: Remove methods only needed for MIPS32. r=#spidermonkey-reviewers!

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c6b46745cb3c
Part 1: Remove mips32 from configure. r=spidermonkey-reviewers,iain
https://hg.mozilla.org/integration/autoland/rev/eafb641d3dd5
Part 2: Remove ifdef code for mips32. r=spidermonkey-reviewers,iain
https://hg.mozilla.org/integration/autoland/rev/d5c8468b1a3d
Part 3: Remove mips32 MacroAssembler definitions. r=spidermonkey-reviewers,iain
https://hg.mozilla.org/integration/autoland/rev/eac0423e991c
Part 4: Remove mips32 source files. r=spidermonkey-reviewers,iain
https://hg.mozilla.org/integration/autoland/rev/1bfdd84800fb
Part 5: Simplify MacroAssembler architecture definitions. r=spidermonkey-reviewers,iain
https://hg.mozilla.org/integration/autoland/rev/3592b039220f
Part 6: Remove MIPS32 specific code from mips-shared. r=spidermonkey-reviewers,iain
https://hg.mozilla.org/integration/autoland/rev/75c5b2014e14
Part 7: Remove methods only needed for MIPS32. r=spidermonkey-reviewers,iain
https://hg.mozilla.org/integration/autoland/rev/d532b3e65a57
apply code formatting via Lando

Comment 10

[amarc]

https://hg.mozilla.org/mozilla-central/rev/c6b46745cb3c
https://hg.mozilla.org/mozilla-central/rev/eafb641d3dd5
https://hg.mozilla.org/mozilla-central/rev/d5c8468b1a3d
https://hg.mozilla.org/mozilla-central/rev/eac0423e991c
https://hg.mozilla.org/mozilla-central/rev/1bfdd84800fb
https://hg.mozilla.org/mozilla-central/rev/3592b039220f
https://hg.mozilla.org/mozilla-central/rev/75c5b2014e14
https://hg.mozilla.org/mozilla-central/rev/d532b3e65a57