Try to remove the NewObjectCache
Categories
(Core :: JavaScript Engine, task, P3)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox94 | --- | fixed |
People
(Reporter: jandem, Assigned: jandem)
References
Details
Attachments
(5 files)
The non-cached allocation path is a lot faster and simpler now, so it might be feasible to remove the cache finally.
The NewObjectCache is biased towards (micro-)benchmarks. On speedometer we seem to be a bit faster without it. Let's try removing it and see how it affects performance.
|
Assignee | |
Comment 1•3 years ago
|
||
|
|
Assignee | |
Comment 2•3 years ago
|
||
Depends on D125042
|
|
Assignee | |
Comment 3•3 years ago
|
||
Depends on D125043
|
|
Assignee | |
Comment 4•3 years ago
|
||
Depends on D125044
|
|
Assignee | |
Comment 5•3 years ago
|
||
Depends on D125045
Pushed by jdemooij@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/92bf998b17e6 part 1 - Remove the NewObjectCache. r=jonco https://hg.mozilla.org/integration/autoland/rev/7e93a0616b8b part 2 - Remove empty Caches-inl.h and Caches.cpp files. r=jonco https://hg.mozilla.org/integration/autoland/rev/a200b4a3797b part 3 - Share more code in NewObject, inline NewObject. r=jonco https://hg.mozilla.org/integration/autoland/rev/6c70c2d67bf4 part 4 - Remove ObjectFlags argument from NewObject and NewObjectWithGivenTaggedProto. r=jonco https://hg.mozilla.org/integration/autoland/rev/6bed21d9876c part 5 - Use same argument order for NewObject and NewObjectWithGivenTaggedProto. r=jonco
|
||
Comment 7•3 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/92bf998b17e6
https://hg.mozilla.org/mozilla-central/rev/7e93a0616b8b
https://hg.mozilla.org/mozilla-central/rev/a200b4a3797b
https://hg.mozilla.org/mozilla-central/rev/6c70c2d67bf4
https://hg.mozilla.org/mozilla-central/rev/6bed21d9876c
|
||
Comment 8•3 years ago
|
||
== Change summary for alert #31291 (as of Mon, 13 Sep 2021 10:34:38 GMT) ==
Improvements:
| Ratio | Test | Platform | Options | Absolute values (old vs new) |
|---|---|---|---|---|
| 0.47% | Base Content JS | macosx1015-64-shippable-qr | fission | 1,737,568.00 -> 1,729,325.33 |
| 0.47% | Base Content JS | windows10-64-2004-shippable-qr | fission | 1,742,744.00 -> 1,734,632.00 |
| 0.47% | Base Content JS | windows10-64-2004-shippable-qr | fission | 1,742,784.00 -> 1,734,546.67 |
For up to date results, see: https://treeherder.mozilla.org/perfherder/alerts?id=31291
Description
•