1730054 - [wpt-sync] Sync PR 30492 - Make TransformState::Move accumulate into existing transform more often.

Status: RESOLVED FIXED

(Core :: Web Painting, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 30492 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/30492
Details from upstream follow.

b'L. David Baron <[e-mail]>' wrote:

Make TransformState::Move accumulate into existing transform more often.

At least when direction_ is kApplyTransformDirection, optimizing away
the modification to the existing transform into a move is not safe.

Without the code change here,
virtual/transform-interop-disabled/external/wpt/css/css-transforms/transform-getBoundingClientRect-001.html
fails (with 75 rather than 125), but
external/wpt/css/css-transforms/transform-getBoundingClientRect-001.html
passes both with and without the change.

Bug: 1247858
Change-Id: Id32a11b2bf66757b0dbbab251c598222f9d120a7
Reviewed-on: https://chromium-review.googlesource.com/3152179
WPT-Export-Revision: 4c16fa2416ffd68cea2a5b3777d52d2f926209ab

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=0dd313c1a6bc9719d1863f466931156ad9757e39

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 11 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 1 subtests

Status Summary

Firefox

OK : 1
PASS: 1

Chrome

OK : 1
PASS: 1

Safari

OK : 1
PASS: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2ab802d128bf
[wpt PR 30492] - Make TransformState::Move accumulate into existing transform more often., a=testonly

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bfd026d3271c
[wpt PR 30492] - Make TransformState::Move accumulate into existing transform more often., a=testonly

Comment 5

[Cristina Cozmuta (:CrissCozmuta)]

https://hg.mozilla.org/mozilla-central/rev/bfd026d3271c