1730117 - Make Document::SuppressEventHandling/UnsuppressEventHandlingAndFireEvents work for nested in-process for Fission

Status: RESOLVED FIXED

(Core :: DOM: UI Events & Focus Handling, defect, P2)

Description

[Edgar Chen [:edgar] (Parental leave until Oct. 09.)]

We should make sure that we handle cases like a.com -iframe> b.com -iframe> a.com by suppress/unsuppress both a.com documents.

Comment 1

[Edgar Chen [:edgar] (Parental leave until Oct. 09.)]

Attachment: Bug 1730117 - Part 1: Make sync XHR suppress event handling for the nested in-process documents;

Comment 2

[Edgar Chen [:edgar] (Parental leave until Oct. 09.)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=3b7efc17cfd8a78bb2a22eaae903ec662f92bd18

Comment 3

[Edgar Chen [:edgar] (Parental leave until Oct. 09.)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=dc04a7f66cbeb211d2ecd776b8230fe4b245080f

Comment 4

[Edgar Chen [:edgar] (Parental leave until Oct. 09.)]

Attachment: Bug 1730117 - Part 2: Make EnterModalState suppress event handling for the nested in-process documents;

Depends on D125187

Comment 5

[Edgar Chen [:edgar] (Parental leave until Oct. 09.)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=b37e5a7d39557bc6da90560ebe9def02d4b852d9

Comment 6

[Edgar Chen [:edgar] (Parental leave until Oct. 09.)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=47e6391e059bd4bf2cd39ab25b234c9dd619c72d

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/37a35b6b54b4
Part 1: Make sync XHR suppress event handling for the nested in-process documents; r=smaug
https://hg.mozilla.org/integration/autoland/rev/649984f4a939
Part 2: Make EnterModalState suppress event handling for the nested in-process documents; r=smaug

Comment 8

[Atila Butkovits]

Backed out for causing failures at test_suppressed_events_nested_iframe.html.

Backout link: https://hg.mozilla.org/integration/autoland/rev/ab5ec599ad1c751183830b6e187ffad0432eee62

Push where failures started: https://treeherder.mozilla.org/jobs?repo=autoland&searchStr=android-em-7-0-x86_64-lite-qr%2Copt%2Cmochitests%2Ctest-android-em-7.0-x86_64-lite-qr%2Fopt-geckoview-mochitest-plain-e10s%2C4&revision=1fc975f877678b2dee224c9d729357c5fca3395d&selectedTaskRun=IsajMbU2Sou9aHwyQb1bqA.0

Failure log: https://treeherder.mozilla.org/logviewer?job_id=352154957&repo=autoland&lineNumber=2701

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/27a1d92e550c
Part 1: Make sync XHR suppress event handling for the nested in-process documents; r=smaug
https://hg.mozilla.org/integration/autoland/rev/bafc4ddc87f6
Part 2: Make EnterModalState suppress event handling for the nested in-process documents; r=smaug

Comment 10

[Sandor Molnar[:smolnar]]

Backed out for causing wpt failures in no_window_open_when_term_nesting_level_nonzero

Backout link

Push with failures

Failure log #1

Failure log #2

Comment 11

[Edgar Chen [:edgar] (Parental leave until Oct. 09.)]

https://treeherder.mozilla.org/jobs?repo=try&group_state=expanded&revision=4a8498699e6ad93ef6096d701b8393d7c31e6c79

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0cc6e1e626be
Part 1: Make sync XHR suppress event handling for the nested in-process documents; r=smaug
https://hg.mozilla.org/integration/autoland/rev/698c991acc52
Part 2: Make EnterModalState suppress event handling for the nested in-process documents; r=smaug

Comment 13

[Cristina Cozmuta (:CrissCozmuta)]

https://hg.mozilla.org/mozilla-central/rev/0cc6e1e626be
https://hg.mozilla.org/mozilla-central/rev/698c991acc52

Comment 14

[Chris Peterson [:cpeterson]]

Setting status-firefox93=wontfix because (I assume!) we don't need to uplift this Fission event suppression fix to Beta 93.