1730218 - SuggestURLTemplate isn't working in SearchEngines policy

Status: RESOLVED FIXED

(Firefox :: Enterprise Policies, defect, P2)

Description

[Mike Kaply [:mkaply]]

SuggestURLTemplate isn't working on policies

It's a typo:

suggestUrlGetParams: newEngine.SuggestURLTemplate,

should be

suggest_url

Comment 1

[Mike Kaply [:mkaply]]

So when we fix this, unfortunately engines that were already added won't get "fixed".

Wondering if there is some clever way to do that?

Comment 2

[Mike Kaply [:mkaply]]

Any ideas Mark?

Comment 3

[Mike Kaply [:mkaply]]

I guess the question is can I easily update the suggest_url in an existing engine.

Comment 4

[Mark Banner (:standard8)]

We don't have an easy way to do this currently.

I think you'd need to have a new function for updatePolicyEngine that call through to engine._updateFromManifest.

That would probably do enough. Though... if we did something like bug 1445134, then we wouldn't have to worry about this since we'd presumably always read/construct from the latest details.

On a possibly separate note, at some stage we should probably think about having strict identifiers for these - not just necessarily the names.

Comment 5

[Mike Kaply [:mkaply]]

Attachment: Bug 1730218 - Fix suggest_url in policies. r?Standard8

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6c28034df317
Fix suggest_url in policies. r=Standard8

Comment 7

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/6c28034df317

Comment 8

[Mike Kaply [:mkaply]]

Comment on attachment 9251024 [details]
Bug 1730218 - Fix suggest_url in policies. r?Standard8

ESR Uplift Approval Request

• If this is not a sec:{high,crit} bug, please state case for ESR consideration: Policy only, parity with 96
• User impact if declined: Suggest URLs don't work in policy
• Fix Landed on Version: 96
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Automated test, policy only.

Requires bug 1481946 first

Comment 9

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9251024 [details]
Bug 1730218 - Fix suggest_url in policies. r?Standard8

Approved for 91.5esr.

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-esr91/rev/1768594a837b