173027 - code-error.html.tmpl misses a </em>

Status: RESOLVED FIXED

(Bugzilla :: User Interface, defect)

Description

[Tobias Burnus]

-    The component <em>[% variables.component FILTER html %] does not exist
+    The component <em>[% variables.component FILTER html %]</em> does not exist

Additional I'd like to ask whether all errors should have an uniq title (as they
do in user-error.html.tmpl) or not ("Internal Error" in code-error.html.tmpl).
In code-error.html.tmpl only 6/33 errors have a title.

Comment 1

[Gervase Markham [:gerv]]

I'll fix this tonight - I assume I have your r= on a change which adds a </em>?

Code Errors don't need a title, really - because they are infrequently
encountered, and the body should contain all the necessary information. Adding
titles just makes more work - and there's some value in code errors having a
consistent title, actually. So maybe we should remove the titles we have.

Gerv

Comment 2

[Tobias Burnus]

> I'll fix this tonight - I assume I have your r= on a change which adds a </em>?
Yes of cause. Or take my minimal patch and give me a r= ;-)
This is "flag_type_component_nonexistent" by the way.

> Code Errors don't need a title, really - because they are infrequently
> encountered, and the body should contain all the necessary information. Adding
> titles just makes more work - and there's some value in code errors having a
> consistent title, actually. So maybe we should remove the titles we have.
I think the titles look ok, but I don't mind to review a patch which removes
those. Is the aaa_example_error_tag still needed?

Comment 3

[Gervase Markham [:gerv]]

Fixed.

Checking in template/en/default/global/code-error.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/global/code-error.html.tmpl,v
 <--  code-error.html.tmpl
new revision: 1.17; previous revision: 1.16
done

Gerv