173035 - Some very small images missing in printout

Status: RESOLVED FIXED

(Core Graveyard :: Printing: Xprint, defect, P2)

Description

[Roland Mainz]

2002-09-29-08-trunk on Solaris/SPARC and Linux/x86:

Some images are missing in the printout of
http://www.ipstat.com/cgi-bin/stats?name=fdg - regardless of the detail if I
turn backgrouns images "ON" or "OFF".

Steps to reproduce:
1. Go to http://www.ipstat.com/cgi-bin/stats?name=fdg
2. Print
3. Check the output, the vertical bars (which are made of scaled images
(http://www.ipstat.com/b1.gif and http://www.ipstat.com/b2.gif) do not show-up
in the printout.

Comment 1

[Roland Mainz]

Attachment: Page 2 of http://www.ipstat.com/cgi-bin/stats?name=fdg (wrong colors are a sdtimage bug)

Comment 2

[Roland Mainz]

Looks that this problem is Xprint-module only...

Comment 3

[Roland Mainz]

Swapping Owner<--->QA ...

Comment 4

[Roland Mainz]

Attachment: Patch for 2002-09-29-08-trunk

Comment 5

[Roland Mainz]

Requesting r=/sr= ...

Comment 6

[Robert O'Callahan (:roc) (email my personal email if necessary)]

> scalingFactor *= (scale_x > scale_y)?(scale_x):(scale_y);

Use PR_MAX. Also, if you don't mind, use PR_MIN for the analogous code a bit
earlier.

With that, sr=roc+moz

Comment 7

[Roland Mainz]

Attachment: New patch for 2002-09-29-08-trunk per roc+moz's sr= comments

Comment 8

[Roland Mainz]

Comment on attachment 102007 [details] [diff] [review]
New patch for 2002-09-29-08-trunk per roc+moz's sr= comments

Marking sr=roc+moz per roc+moz's permission on IRC...

Comment 9

[Simon Montagu :smontagu]

Fix checked in.