CSS containment should block propagation from body to viewport
Categories
(Core :: Layout, defect)
Tracking
()
Tracking | Status | |
---|---|---|
firefox103 | --- | fixed |
People
(Reporter: rune.lillesveen, Assigned: emilio)
Details
Attachments
(1 file)
User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/93.0.4577.63 Safari/537.36
Steps to reproduce:
Tests like [1] fail in Gecko. The css-contain spec[2] has been changed after the CSSWG resolution in [3] stopping propagation from body to viewport for non-none used containment on root and body.
[1] https://wpt.fyi/css/css-contain/contain-body-bg-001.html fail in Gecko.
[2] https://drafts.csswg.org/css-contain-1/#c3
[3] https://github.com/w3c/csswg-drafts/issues/5913
Actual results:
WPT tests failed
Expected results:
WPT tests passed
Comment 1•3 years ago
|
||
The Bugbug bot thinks this bug should belong to the 'Core::Layout' component, and is moving the bug to that component. Please revert this change in case you think the bot is wrong.
Comment 2•3 years ago
|
||
Hey Daniel! Does this seem like something Gecko would want to ship? Rune has sent an Intent to Ship for Chromium @ https://groups.google.com/a/chromium.org/g/blink-dev/c/LYuQvgjLhe0.
Comment 3•3 years ago
|
||
Sure, makes sense to ship this change. Hopefully I or somebody can get to it ~soon.
Updated•3 years ago
|
Assignee | ||
Comment 4•2 years ago
|
||
Updated•2 years ago
|
Pushed by ealvarez@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/392445118046 Fix containment and body-to-root propagation. r=dholbert
Pushed by emilio@crisal.io: https://hg.mozilla.org/integration/autoland/rev/350982d1a44d Fix typo that causes some reftests to fail.
Comment 7•2 years ago
|
||
Backed out for causing multiple reftest failures.
First push with failures
Push with the fix for the first batch of failures
Failure log for when it fails on layout/reftests/writing-mode/1102175-1a.html
Failure log for when it fails on layout/reftests/bidi/817406-4.html
Failure log for when it fails on layout/reftests/bugs/379461-3-container-xhtml.html
Failure log for wr job with fail on /css/css-backgrounds/background-color-body-propagation-009.html
Failure log for wr job on the push with the fix
Updated•2 years ago
|
Assignee | ||
Updated•2 years ago
|
Pushed by ealvarez@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/d70914c7f1f3 Fix containment and body-to-root propagation. r=dholbert
Comment 9•2 years ago
|
||
Backed out changeset d70914c7f1f3 (Bug 1730763) for causing web-platform reftest failures on direction-propagation-body-contain-root.html.
Backout link
Push with failures <--> Wr2
Failure Log
Comment 10•2 years ago
|
||
Looks like some more unexpected passes (hooray!), so there are just some more .ini files to remove, probably.
Assignee | ||
Updated•2 years ago
|
Comment 11•2 years ago
|
||
Pushed by ealvarez@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/a5403b470ac6 Fix containment and body-to-root propagation. r=dholbert
Comment 12•2 years ago
|
||
bugherder |
Description
•