1730968 - Browser toolbox breakpoints are not respected when removed in Form Autofill components

Status: RESOLVED FIXED

(DevTools :: Debugger, defect, P2)

Description

[Tim Giles [:tgiles]]

STR:

1. Enable credit card autofill by setting "extensions.formautofill.available" to true. Edit: you probably want to update "extensions.formautofill.creditCards.supported" to "on" instead of the previous pref.
2. Restart browser so pref can take effect
3. Add credit card to "about:preferences" -> Saved Credit Cards. I just use a number off paypal's test list
4. Navigate to one of the form fill test pages
5. Open browser toolbox and set a breakpoint in FormAutofillHandler at line 210, or the first line under "matchSelectOptions". Permalink for reference.
6. Click a field on the test page and notice the breakpoint is triggered
7. Remove breakpoint
8. Click a field on the test page and notice the breakpoint is still triggered

Expected results:
Breakpoint is not triggered after removal

Actual results:
Breakpoint is triggered after removal. You must restart the browser toolbox in order to remove the reference to the breakpoint.

I have no idea why this is happening, and I verified this doesn't happen in the password manager code (which is the other part of the codebase that I'm familiar with). I'm guessing this is something to do with how the form autofill component is structured but I'm not sure.

Comment 1

[Hubert Boma Manilla (:bomsy)]

Thanks for reporting! I added some update notes to the STR

(In reply to Tim Giles [:tgiles] from comment #0)

STR:

1. Enable credit card autofill by setting "extensions.formautofill.available" to true.

This would probably be extensions.formautofill.available to "on".

5. Open browser toolbox and set a breakpoint in FormAutofillHandler at line 210, or the first line under "matchSelectOptions". Permalink for reference.

If the FormAutofillHandler.jsm is not available, click in a field on the test page first

I have no idea why this is happening, and I verified this doesn't happen in the password manager code (which is the other part of the codebase that I'm familiar with). I'm guessing this is something to do with how the form autofill component is structured but I'm not sure.

We have been having random issues with removed breakpoints still triggering.

Thanks for the STR.

Comment 2

[Nicolas Chevobbe [:nchevobbe]]

Chasing zombie breakpoints seems important

Comment 3

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1730968 - [devtools] Fix typo preventing to remove data entries.

This probably had many side effects in the browser toolbox when debugging content processes.
But the main one was about not properly unregistering breakpoints when removing/disabling it.
This is only specific to content process targets, so this is only impacting the browser toolbox.

Comment 4

[Alexandre Poirot [:ochameau]]

Sorry for the delay and thanks Tim for the STR.

This helped undercover a significant issue around content process debugging.

I hope things will be much better after this one fix and we should keep polishing the debugger this quarter.

Try run for this patch:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=27c8d03660a5acd96af844b02b655e9806889dc1

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/eeb80cc8d978
[devtools] Fix typo preventing to remove data entries. r=bomsy

Comment 6

[Cristina Cozmuta (:CrissCozmuta)]

https://hg.mozilla.org/mozilla-central/rev/eeb80cc8d978

Comment 7

[Alexandre Poirot [:ochameau]]

Hi Tim

Could you confirm we fixed the issues you were having?
Your STR was actually super useful.
Let us know if you have any other issues with the debugger.

Comment 8

[Tim Giles [:tgiles]]

Just confirmed the issue is fixed for me on the latest pull of central. Thank you for resolving this, you've already made my week great! I've had so much frustration with our form autofill debugging due to these zombie breakpoints and now things appear to behave as expected.