Restore additional mailto protocol handlers in localized repos
Categories
(Mozilla Localizations :: Other, enhancement)
Tracking
(firefox93 fixed, firefox94 fixed)
People
(Reporter: karlcow, Assigned: flod)
References
Details
There was an issue reported by a user on webcompat.com
gmail is not part of the mailto protocol handler suggested for Russian locales.
|
Reporter | |
Comment 1•3 years ago
|
||
|
|
Reporter | |
Comment 2•3 years ago
|
||
Glandium found out it was removed in the past
https://hg.mozilla.org/l10n-central/ru/rev/83d740c63b21000915f838b8b6ae9278035a3755
|
Assignee | |
Comment 3•3 years ago
|
||
We have a script that removes obsolete strings from repositories.
https://github.com/flodolo/fluent-migrations/blob/master/scripts/remove_obsolete_files.py
Unfortunately, I and the reviewer at the time didn't think of locales who more than two mailto protocol handlers.
This is the result of having this information stored in the wrong type of file (.properties) and in l10n repositories, while it should be centralized.
There are way too many places where this can be messed up with: I used to have checks for these files, but they were removed when we moved search out of l10n repositories.
And please, remove yandex.mail and mail.ru for ukraine, they both blocked in my country.
|
|
Assignee | |
Updated•3 years ago
|
|
|
Assignee | |
Comment 5•3 years ago
|
||
Fixes:
https://hg.mozilla.org/l10n-central/es-CL/rev/67b34d61d92668ce9423a7170e1fa883abb188fb
https://hg.mozilla.org/l10n-central/kk/rev/3926c0328eed16bfedad98d9bdf4218e61b324f2
https://hg.mozilla.org/l10n-central/lv/rev/2b6d9aed0ceef933b345b248000ede885440b1e2
https://hg.mozilla.org/l10n-central/ltg/rev/c80ed84771358876cbbb401a051d06b04d2cfe79
https://hg.mozilla.org/l10n-central/ru/rev/1a33d1e02a4ba80a7b7ff603bda8dae18674ae10
Script fix:
https://github.com/flodolo/fluent-migrations/commit/8bd1b2c710019ed74ca52a0ccece096415abf8c9
This will be picked up in 93+, not sure it makes a lot of sense to update ESR91, since this change was made in May 2020, so it shipped even in ESR78.
|
|
Assignee | |
Updated•3 years ago
|
|
|
Assignee | |
Comment 6•3 years ago
|
||
Follow-up: I realized that, while still restore an existing version of the handlers, it might be a good idea to increase the defaultHandlersVersion.
|
|
Assignee | |
Comment 7•3 years ago
|
||
(In reply to soredake from comment #4)
And please, remove yandex.mail and mail.ru for ukraine, they both blocked in my country.
These settings are per locale, not per region, and Ukrainian doesn't have any of those
https://hg.mozilla.org/l10n-central/uk/file/tip/browser/chrome/browser-region/region.properties
Description
•