1731091 - Phantom event at the end of each day

Status: VERIFIED FIXED

(Calendar :: General, defect)

Description

[Ilia Kats]

Attachment: Screenshot_20210916_171221.png

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:92.0) Gecko/20100101 Firefox/92.0

Actual results:

The calendar displays an event at the very end of each day (see attached screenshot). I did not enter these events, they cannot be edited (double-clicking them does nothing), and the tooltip when hovering is that of any other event that I hovered over previously. To be precise, right after starting Thunderbird, there is no tooltip. If I hover over any other event, say X, and then over the phantom event, then the tooltip of the phantom event will be identical to that of event X. If I next hover over event Y and then over the phantom event, the tooltip will be identical to that of event Y.

The phantom events show up in both daily view and weekly view. I'm not certain, but I think this did not occur in TB 78, only since TB 91.

Comment 1

[Geoff Lankow (:darktrojan)]

Well that's a weird one! Are they associated with any particular calendar (ie. do they go away if you hide that calendar)? If so can you export the calendar and check for anything unusual?

Comment 2

[Ilia Kats]

Attachment: Screenshot_20210917_083847.png

It does not appear so. I've hidden all my calendars, the phantoms are still there.

Comment 3

[Richard Marti (:Paenglab)]

Geoff, the "phantom" event is defined here https://searchfox.org/comm-central/rev/d3417c4dd066060bf1bdd0ed5424d14514121da2/calendar/base/content/calendar-event-column.js#47 and shown because of this rule https://searchfox.org/comm-central/rev/35c9e2929a5ae37d07192315db3787dc01f73441/calendar/base/themes/common/calendar-views.css#506

Does the <calendar-event-box> need to be defined there as a prototype? If yes, a calendar-event-box:not([hidden="true]) should do the trick to hide the phantom events.

Comment 4

[Geoff Lankow (:darktrojan)]

Ohhh, right, that thing. I'd forgotten about it. Henry's patch must've made it appear by setting the display.

Comment 5

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1731091 - Hide the dummy event box in <calendar-event-column>s. r=Paenglab

Comment 6

[Geoff Lankow (:darktrojan)]

Thanks for pointing out what I missed, Richard.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/f00c9ad6c03b
Hide the dummy event box in <calendar-event-column>s. r=Paenglab

Comment 8

[Geoff Lankow (:darktrojan)]

Comment on attachment 9241744 [details]
Bug 1731091 - Hide the dummy event box in <calendar-event-column>s. r=Paenglab

[Approval Request Comment]
Regression caused by (bug #): bug 1694820
User impact if declined: an extra box appears at the bottom of each column in the day/week calendar
Testing completed (on c-c, etc.): landed 6 days ago
Risk to taking this patch (and alternatives if risky): low

Comment 9

[Wayne Mery (:wsmwk)]

Comment on attachment 9241744 [details]
Bug 1731091 - Hide the dummy event box in <calendar-event-column>s. r=Paenglab

[Triage Comment]
Approved for beta

Comment 10

[Rob Lemley [:rjl]]

Thunderbird 93.0b5:
https://hg.mozilla.org/releases/comm-beta/rev/287e52719ca0

Comment 11

[Geoff Lankow (:darktrojan)]

Comment on attachment 9241744 [details]
Bug 1731091 - Hide the dummy event box in <calendar-event-column>s. r=Paenglab

[Approval Request Comment]
Regression caused by (bug #): bug 1694820
User impact if declined: an extra box appears at the bottom of each column in the day/week calendar
Testing completed (on c-c, etc.): only in 93.0b5 but I'm okay with that
Risk to taking this patch (and alternatives if risky): low

Comment 12

[Wayne Mery (:wsmwk)]

Comment on attachment 9241744 [details]
Bug 1731091 - Hide the dummy event box in <calendar-event-column>s. r=Paenglab

[Triage Comment]
Approved for esr91

Comment 13

[Rob Lemley [:rjl]]

Thunderbird 91.2.0:
https://hg.mozilla.org/releases/comm-esr91/rev/4b1f6115ca95

Comment 14

[WaltS48 [:walts48]]

Verified testing the 91.2 release candidate on Windows 10.