1731197 - [Linux] Don't query missing D&D targets

Status: RESOLVED FIXED

(Core :: Widget: Gtk, defect)

Description

[Martin Stránský [:stransky] (ni? me)]

Don't query missing D&D targets - it wastes resources and makes D&D longer.

Comment 1

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 1731197 [Linux] Make D&D operations more reliable and transfer only available D&D data types, r?emilio

Right now we query all MIME data types during D&D operation and rely on Gtk to filter out
missing ones. It leads to possible D&D failures as we can't process D&D events
from Gtk during it.

This patch does:

• Query MIME types available for D&D transfer by nsDragService::GetDragFlavors().
• Quit early at nsDragService::GetTargetDragData() when requested MIME can't be transferred by D&D.
• Use gdk_drag_context_get_suggested_action() instead of gdk_drag_context_get_actions().
• Check mTargetWindow before we use it.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f213f078a6d2
[Linux] Make D&D operations more reliable and transfer only available D&D data types, r=emilio

Comment 3

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/f213f078a6d2

Comment 4

[Natalia Csoregi [:nataliaCs]]

Backed out along with Bug 1730203 for drag and drop of tabs causing duplicates (Bug 1732116).

backout: https://hg.mozilla.org/mozilla-central/rev/ba378c62cecf6a3048baddde1f9c7d61b45a2914

Comment 5

[Martin Stránský [:stransky] (ni? me)]

(In reply to Natalia Csoregi [:nataliaCs] from comment #4)

Backed out along with Bug 1730203 for drag and drop of tabs causing duplicates (Bug 1732116).

backout: https://hg.mozilla.org/mozilla-central/rev/ba378c62cecf6a3048baddde1f9c7d61b45a2914

No need to backout that, a fix is already at Bug 1732116.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/dfa8def98594
[Linux] Make D&D operations more reliable and transfer only available D&D data types, r=emilio

Comment 7

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

(In reply to Martin Stránský [:stransky] (ni? me) from comment #5)

No need to backout that, a fix is already at Bug 1732116.

The fix was still pending review and we needed to ship a fixed Nightly asap.

Comment 8

[Marco Castelluccio [:marco]]

Martin, I've noticed that copying and pasting images in Telegram chats has stopped working reliably around the same time. Could it be related to one of these recent changes?

Comment 9

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/dfa8def98594

Comment 10

[Martin Stránský [:stransky] (ni? me)]

(In reply to Marco Castelluccio [:marco] from comment #8)

Martin, I've noticed that copying and pasting images in Telegram chats has stopped working reliably around the same time. Could it be related to one of these recent changes?

This is about D&D only. Please file a new bug for copy/paste bug. Do you use Wayland or X11?

Comment 11

[Marco Castelluccio [:marco]]

Yeah, I filed bug 1732681.