1731232 - should allow/suggest key publication on key server

Status: RESOLVED FIXED

(MailNews Core :: Security: OpenPGP, enhancement)

Description

[Magnus Melin [:mkmelin]]

Users may not know about key servers, but publishing the key on a server is many times essential for people to discover your key. We should allow, and suggest for users to publish their public key on a key server.

There's some (unclear how functionally complete) code for this in the tree: https://searchfox.org/comm-central/rev/35c9e2929a5ae37d07192315db3787dc01f73441/mail/extensions/openpgp/content/modules/keyserver.jsm#431

Comment 1

[andrewg]

It should also be possible (and in the future recommended) to publish using WKS. Enigmail had quite advanced support for this.

Comment 2

[Kai Engert [:KaiE:]]

WKS should be a separate bug, because it requires completely different code.

Comment 3

[Kai Engert [:KaiE:]]

Attachment: Bug 1731232 - Support OpenPGP public key upload to vks and hkp keyserver. r=PatrickBrunschwig

Depends on D163136

Comment 4

[Kai Engert [:KaiE:]]

The attached patch implements uploading to VKS and HKP keyserver.

To decide to which keyserver to upload to, the code will look at the new pref mail.openpgp.keyserver_list (added in bug 1640511). It will consider the first entry the highest priority. However, if the entry uses an unsupported protocol, it will skip to the first entry that is supported.

To trigger uploading, you have to open OpenPGP key manager, select one of your personal keys (bold), then use the KeyServer menu and select "publish".

We can consider to add more entry points for uploading in the future, to make it easier discoverable.

Comment 5

[Kai Engert [:KaiE:]]

https://hg.mozilla.org/comm-central/rev/265db0c182d3dc09be1ae31212b5b3d0cf902df3

Comment 6

[Kai Engert [:KaiE:]]

(In reply to andrewg from comment #1)

It should also be possible (and in the future recommended) to publish using WKS. Enigmail had quite advanced support for this.

The Enigmail implementation called functionality from GnuPG.
Because Thunderbird doesn't have GnuPG available by default, it's not as easy for us to do.
Nevertheless, that request is already being tracked in bug 1695048.

Comment 7

[Rob Lemley [:rjl]]

Per comment in Phabricator on the string changes:
https://hg.mozilla.org/comm-central/rev/8bd16fef3715f34ece874f524e079ed0d351c5c9

Comment 8

[Kai Engert [:KaiE:]]

Rob, wouldn't have it been more efficient to allow me to simply create a follow-up patch?

Comment 9

[Kai Engert [:KaiE:]]

Never mind, I realize I still can make an incremental patch, by reusing the existing changes in phabricator, and creating an incremental new revision on top of it.

Comment 10

[Kai Engert [:KaiE:]]

Rob, given that the string was already commited, should I use different string IDs for the updated strings?

Comment 11

[Kai Engert [:KaiE:]]

Attachment: Bug 1731232 - Follow-up to address reviewer comments. r=aleca

Depends on D163189

Comment 12

[Rob Lemley [:rjl]]

(In reply to Kai Engert (:KaiE:) from comment #10)

Rob, given that the string was already commited, should I use different string IDs for the updated strings?

You can use the same IDs because the strings were never exposed for localization.

Comment 13

[Kai Engert [:KaiE:]]

Comment on attachment 9305529 [details]
Bug 1731232 - Support OpenPGP public key upload to vks and hkp keyserver. r=PatrickBrunschwig

I'd appreciate inclusion of this enhancement into comm-beta, because the code was already landed on c-c earlier, it worked fine, and it was backed out only because minor changes were requested by reviewers.

[Approval Request Comment]
Regression caused by (bug #): no
User impact if declined: feature missing, but already announced
Testing completed (on c-c, etc.): was already on c-c earlier
Risk to taking this patch (and alternatives if risky): low

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/1006ac91779b
Support OpenPGP public key upload to vks and hkp keyserver. r=PatrickBrunschwig
https://hg.mozilla.org/comm-central/rev/0dffc528c881
Follow-up to address reviewer comments. r=aleca

Comment 15

[Wayne Mery (:wsmwk)]

Comment on attachment 9305529 [details]
Bug 1731232 - Support OpenPGP public key upload to vks and hkp keyserver. r=PatrickBrunschwig

[Triage Comment]
Approved for beta

Comment 16

[Wayne Mery (:wsmwk)]

Comment on attachment 9307173 [details]
Bug 1731232 - Follow-up to address reviewer comments. r=aleca

[Triage Comment]
Approved for beta

Comment 17

[Daniel Darnell [:dandarnell]]

Thunderbird 109.0b2:
https://hg.mozilla.org/releases/comm-beta/rev/739f26500e69
https://hg.mozilla.org/releases/comm-beta/rev/cb694516bb7c