Closed Bug 1731252 Opened 1 year ago Closed 1 year ago

[wpt-sync] Sync PR 30705 - Validate XRRigidTransform Constructor Arguments

Categories

(Core :: WebVR, task, P4)

task

Tracking

()

RESOLVED FIXED
95 Branch
Tracking Status
firefox95 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 30705 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/30705
Details from upstream follow.

b'Alexander Cooper <alcooper@chromium.org>' wrote:

Validate XRRigidTransform Constructor Arguments

Per the spec, XRRigidTransform's created with DOMPoint's which contain
non-finite (e.g. NaN/Infinity) should throw a type error and fail to
be created. While not doing so seems to work fine on production builds
(seeming to default to using identity for the component which had the
invalid portion), on DCHECK builds, these poorly constructed objects
start to hit DCHECKs when methods on the object are attempted to be
used.

This fixes the XRRigidTransform::Create method to appropriately throw
per the spec and thus should avoid the later DCHECKs. This change also
adds a WPT to validate this specced behavior.

Fixed: 1246156
Change-Id: I5d13784868056896f15b8c803ce4b6abb69f03fc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3159085
Auto-Submit: Alexander Cooper \<alcooper@chromium.org>
Reviewed-by: Piotr Bialecki \<bialpio@chromium.org>
Commit-Queue: Alexander Cooper \<alcooper@chromium.org>
Cr-Commit-Position: refs/heads/main@{#921244}

Component: web-platform-tests → WebVR
Product: Testing → Core

CI Results

Ran 11 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 2 subtests

Status Summary

Firefox

OK : 1
FAIL: 2

Chrome

OK : 1
FAIL: 2

Safari

OK : 1
FAIL: 2

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/webxr/xrRigidTransform_constructor.https.html: OK [Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-linux1804-64-tsan-qr-opt, Gecko-windows10-32-2004-qr-debug, Gecko-windows10-32-2004-qr-opt, Gecko-windows10-64-2004-qr-debug, Gecko-windows10-64-2004-qr-opt, GitHub], SKIP [Gecko-android-em-7.0-x86_64-lite-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview] (Chrome: OK, Safari: OK)
XRRigidTransform constructor works - webgl: FAIL (Chrome: FAIL, Safari: FAIL)
XRRigidTransform constructor works - webgl2: FAIL (Chrome: FAIL, Safari: FAIL)

Tests Disabled in Gecko Infrastructure

/webxr/xrRigidTransform_constructor.https.html: OK [Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-linux1804-64-tsan-qr-opt, Gecko-windows10-32-2004-qr-debug, Gecko-windows10-32-2004-qr-opt, Gecko-windows10-64-2004-qr-debug, Gecko-windows10-64-2004-qr-opt, GitHub], SKIP [Gecko-android-em-7.0-x86_64-lite-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview] (Chrome: OK, Safari: OK)

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a26191f580dd
[wpt PR 30705] - Validate XRRigidTransform Constructor Arguments, a=testonly
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/4802139be929
[wpt PR 30705] - Validate XRRigidTransform Constructor Arguments, a=testonly
Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → 95 Branch
You need to log in before you can comment on or make changes to this bug.