Closed Bug 1731291 Opened 3 months ago Closed 2 months ago

Permanent bustage js/src/wasm/WasmJS.cpp:1437:21: error: use of undeclared identifier 'FuncTypeToObject when Gecko 94 merges to Beta on 2021-10-04

Categories

(Core :: Javascript: WebAssembly, defect, P2)

defect

Tracking

()

VERIFIED FIXED
94 Branch
Tracking Status
firefox-esr78 --- unaffected
firefox-esr91 --- unaffected
firefox92 --- unaffected
firefox93 --- unaffected
firefox94 blocking verified

People

(Reporter: aryx, Assigned: rhunt)

References

(Blocks 1 open bug, Regression)

Details

(Keywords: regression)

Attachments

(1 file)

2:37.42 /builds/worker/checkouts/gecko/js/src/wasm/WasmJS.cpp:1437:21: error: use of undeclared identifier 'FuncTypeToObject'
2:37.42 /builds/worker/checkouts/gecko/js/src/wasm/WasmJS.cpp:1444:21: error: use of undeclared identifier 'TableTypeToObject'
2:37.42 /builds/worker/checkouts/gecko/js/src/wasm/WasmJS.cpp:1453:15: error: use of undeclared identifier 'MemoryTypeToObject'
2:37.42 /builds/worker/checkouts/gecko/js/src/wasm/WasmJS.cpp:1460:21: error: use of undeclared identifier 'GlobalTypeToObject'; did you mean 'GlobalObject'?
2:37.42 /builds/worker/checkouts/gecko/js/src/wasm/WasmJS.cpp:1546:21: error: use of undeclared identifier 'FuncTypeToObject'
2:37.42 /builds/worker/checkouts/gecko/js/src/wasm/WasmJS.cpp:1551:21: error: use of undeclared identifier 'TableTypeToObject'
2:37.42 /builds/worker/checkouts/gecko/js/src/wasm/WasmJS.cpp:1558:15: error: use of undeclared identifier 'MemoryTypeToObject'
2:37.42 /builds/worker/checkouts/gecko/js/src/wasm/WasmJS.cpp:1564:21: error: use of undeclared identifier 'GlobalTypeToObject'; did you mean 'GlobalObject'?
Flags: needinfo?(rhunt)
Assignee: nobody → rhunt
Flags: needinfo?(rhunt)

The pre-existing code for printing a function type to string used a check
behind 'fuzzingSafe' and I cannot find a reason for this in any
commit history. Searchfox thinks it came from the original commit
for the imports/exports feature from luke, but it's not present
in the commits he landed, nor in the bug. I don't think it's
necessary, so I think we should remove it while we're fixing
this bug.

Changing severity from -- to S2 because red is not green.

Severity: -- → S3
Status: NEW → ASSIGNED
Priority: -- → P2
Blocks: 1729505

More code that needs to be behind the ifdef. I've update the patch.

Flags: needinfo?(rhunt)
Pushed by rhunt@eqrion.net:
https://hg.mozilla.org/integration/autoland/rev/9ad1733e113b
wasm: Hide .type property of imports/exports behind compile-time flag. r=lth
Status: ASSIGNED → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → 94 Branch
You need to log in before you can comment on or make changes to this bug.