Closed Bug 1731321 Opened 1 year ago Closed 1 year ago

[wpt-sync] Sync PR 30781 - [Re-Factor Client Hints] (5) Remove (unlaunched) `lang` client hint

Categories

(Testing :: web-platform-tests, task, P4)

task

Tracking

(firefox95 fixed)

RESOLVED FIXED
95 Branch
Tracking Status
firefox95 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 30781 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/30781
Details from upstream follow.

b'Ari Chivukula <arichiv@chromium.org>' wrote:

[Re-Factor Client Hints] (5) Remove (unlaunched) lang client hint

Now that we've cleaned up the array indexing that was blocking this,
let's move forward with removing this unused client hint.

This is a part of a series of CLs to re-factor the client hints code:
(1) Label hints with legacy names
(2) Fix the naming of (unlaunched) lang client hint
(3) Consolidate client hint name lists
(4) Migrate from array to map indexing for client hint names
(5) Remove (unlaunched) lang client hint

Bug: 1227043
Change-Id: I57404516cd1f39f738f0fbd7c202de7adf063d98
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3160286
Auto-Submit: Ari Chivukula \<arichiv@chromium.org>
Commit-Queue: Matt Falkenhagen \<falken@chromium.org>
Reviewed-by: Matt Falkenhagen \<falken@chromium.org>
Reviewed-by: David Dorwin \<ddorwin@chromium.org>
Reviewed-by: Yoav Weiss \<yoavweiss@chromium.org>
Reviewed-by: Dominick Ng \<dominickn@chromium.org>
Cr-Commit-Position: refs/heads/main@{#921893}

PR 30781 applied with additional changes from upstream: eb90781d3ec0766b56286dbb19ecb31dc2c8369d

CI Results

Ran 11 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 10 tests and 1 subtests

Status Summary

Firefox

OK : 10
PASS: 8
FAIL: 5

Chrome

OK : 10
PASS: 9
FAIL: 4

Safari

OK : 10
PASS: 7
FAIL: 6

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/client-hints/accept-ch-answers.sub.https.html
Accept-CH header test: FAIL (Chrome: PASS, Safari: FAIL)
/client-hints/accept-ch-feature-policy.sub.https.html
Accept-CH header test: FAIL (Chrome: PASS, Safari: FAIL)
Cross-Origin Accept-CH header test: FAIL (Chrome: PASS, Safari: FAIL)
/client-hints/accept-ch-no-feature-policy.sub.https.html
Accept-CH header test: FAIL (Chrome: PASS, Safari: FAIL)
/client-hints/http-equiv-accept-ch-merge.https.html
Accept-CH header test: FAIL (Chrome: PASS, Safari: FAIL)

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/fc751892e985
[wpt PR 30781] - [Re-Factor Client Hints] (5) Remove (unlaunched) `lang` client hint, a=testonly
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/36ee490d1bdd
[wpt PR 30781] - [Re-Factor Client Hints] (5) Remove (unlaunched) `lang` client hint, a=testonly
Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → 95 Branch
You need to log in before you can comment on or make changes to this bug.