Closed Bug 1731330 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 30787 - FSA: Add web tests for FileSystemHandle::rename()

Categories

(Testing :: web-platform-tests, task, P4)

Product:
Testing
Component:
web-platform-tests
Type:
task

Tracking

(firefox95 fixed)

Status:
RESOLVED FIXED
Milestone:
95 Branch
Tracking Flags:
Tracking Status
firefox95 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 30787 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/30787
Details from upstream follow.

b'Austin Sullivan <asully@chromium.org>' wrote:

FSA: Add web tests for FileSystemHandle::rename()

These tests were accidentally lost while iterating on
https://crrev.com/c/2984739. They have been recovered from
https://crrev.com/c/2984739/28.

Bug: 1140805
Change-Id: I3aeef4ad1094931f9ce07bec3c261da9741d45bd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3160902
Reviewed-by: Marijn Kruisselbrink \<mek@chromium.org>
Commit-Queue: Austin Sullivan \<asully@chromium.org>
Cr-Commit-Position: refs/heads/main@{#922261}

CI Results

Ran 11 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 2 tests and 10 subtests

Status Summary

Firefox

OK : 2
FAIL: 20

Chrome

OK : 2
PASS: 20

Safari

OK : 2
FAIL: 20

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/file-system-access/sandboxed_FileSystemBaseHandle-rename.https.any.worker.html
rename(name) to rename a file: FAIL (Chrome: PASS, Safari: FAIL)
rename(name) to rename a file the same name: FAIL (Chrome: PASS, Safari: FAIL)
rename("") to rename a file fails: FAIL (Chrome: PASS, Safari: FAIL)
rename(name) to rename an empty directory: FAIL (Chrome: PASS, Safari: FAIL)
rename("") to rename an empty directory fails: FAIL (Chrome: PASS, Safari: FAIL)
rename(name) to rename a non-empty directory: FAIL (Chrome: PASS, Safari: FAIL)
rename(name) can be called multiple times: FAIL (Chrome: PASS, Safari: FAIL)
rename(dir) should rename to stringified dir object: FAIL (Chrome: PASS, Safari: FAIL)
rename(name) with a name with a trailing period should fail: FAIL (Chrome: PASS, Safari: FAIL)
rename(name) with a name with invalid characters should fail: FAIL (Chrome: PASS, Safari: FAIL)
/file-system-access/sandboxed_FileSystemBaseHandle-rename.https.any.html
rename(name) to rename a file: FAIL (Chrome: PASS, Safari: FAIL)
rename(name) to rename a file the same name: FAIL (Chrome: PASS, Safari: FAIL)
rename("") to rename a file fails: FAIL (Chrome: PASS, Safari: FAIL)
rename(name) to rename an empty directory: FAIL (Chrome: PASS, Safari: FAIL)
rename("") to rename an empty directory fails: FAIL (Chrome: PASS, Safari: FAIL)
rename(name) to rename a non-empty directory: FAIL (Chrome: PASS, Safari: FAIL)
rename(name) can be called multiple times: FAIL (Chrome: PASS, Safari: FAIL)
rename(dir) should rename to stringified dir object: FAIL (Chrome: PASS, Safari: FAIL)
rename(name) with a name with a trailing period should fail: FAIL (Chrome: PASS, Safari: FAIL)
rename(name) with a name with invalid characters should fail: FAIL (Chrome: PASS, Safari: FAIL)

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d8855ba324cf
[wpt PR 30787] - FSA: Add web tests for FileSystemHandle::rename(), a=testonly
https://hg.mozilla.org/integration/autoland/rev/2dcbb39aa0ad
[wpt PR 30787] - Update wpt metadata, a=testonly
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/3f8fba55b43e
[wpt PR 30787] - FSA: Add web tests for FileSystemHandle::rename(), a=testonly
https://hg.mozilla.org/integration/autoland/rev/47fb3b86a41c
[wpt PR 30787] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/3f8fba55b43e
https://hg.mozilla.org/mozilla-central/rev/47fb3b86a41c

Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox95: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 95 Branch
You need to log in before you can comment on or make changes to this bug.