1731494 - There is no spacing between "new tab" and "learn more" in the prompt that comes when an extension changes the new tab page.

Status: VERIFIED FIXED

(Firefox :: Theme, defect)

Description

[Aaron Rodrigues]

Attachment: Screenshot 2021-09-19 at 16.03.04.png

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:92.0) Gecko/20100101 Firefox/92.0

Steps to reproduce:

Download an extension that gives a customized new tab page e.g Momentum and open a new tab.

Actual results:

There will be no spacing between "new tab" and "learn more" in the prompt that comes when an extension changes the new tab page.

Expected results:

There should be spacing between "new tab" and "learn more" in the prompt.

Comment 1

[BugBot [:suhaib / :marco]]

The Bugbug bot thinks this bug should belong to the 'Firefox::Tabbed Browser' component, and is moving the bug to that component. Please revert this change in case you think the bot is wrong.

Comment 2

[Marcela (Please NI request to Brindusa Tot)]

I was able to reproduce this issue on latest Nightly version 94.0a1 (2021-09-20)(64-bit) on macOS 11, and Windows 10.
I'll change flags accordingly. Please If is not the correct component please feel free to change it to an appropriate one.

Comment 3

[:Gijs (he/him)]

Please stop using the proton whiteboard tags and meta trackers.

It looks like webextensions are the only consumers of learnMoreMessageId. I can't quite tell if this is a new regression or not. Marcela, can you check?

Comment 4

[Marcela (Please NI request to Brindusa Tot)]

(In reply to :Gijs (he/him) from comment #3)

Please stop using the proton whiteboard tags and meta trackers.

It looks like webextensions are the only consumers of learnMoreMessageId. I can't quite tell if this is a new regression or not. Marcela, can you check?

I've run mozregression and this is the PushLog:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=7729d9f5878dc822927afbd07479a0a3b3b46d6f&tochange=44916257e3052502b8d9465b73be4d5a8c4919e7

Comment 5

[:Gijs (he/him)]

(In reply to Marcela from comment #4)

(In reply to :Gijs (he/him) from comment #3)

Please stop using the proton whiteboard tags and meta trackers.

It looks like webextensions are the only consumers of learnMoreMessageId. I can't quite tell if this is a new regression or not. Marcela, can you check?

I've run mozregression and this is the PushLog:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=7729d9f5878dc822927afbd07479a0a3b3b46d6f&tochange=44916257e3052502b8d9465b73be4d5a8c4919e7

That just points to proton styling being enabled. Could you re-run mozregression with browser.proton.doorhangers.enabled set to true via the commandline switch to mozregression? You can use 44916257e3052502b8d9465b73be4d5a8c4919e7 as the initial --bad parameter, and probably --good 86 or similar, to make it go more quickly.

Comment 6

[Marcela (Please NI request to Brindusa Tot)]

(In reply to :Gijs (he/him) from comment #5)

(In reply to Marcela from comment #4)

(In reply to :Gijs (he/him) from comment #3)

Please stop using the proton whiteboard tags and meta trackers.

It looks like webextensions are the only consumers of learnMoreMessageId. I can't quite tell if this is a new regression or not. Marcela, can you check?

I've run mozregression and this is the PushLog:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=7729d9f5878dc822927afbd07479a0a3b3b46d6f&tochange=44916257e3052502b8d9465b73be4d5a8c4919e7

That just points to proton styling being enabled. Could you re-run mozregression with browser.proton.doorhangers.enabled set to true via the commandline switch to mozregression? You can use 44916257e3052502b8d9465b73be4d5a8c4919e7 as the initial --bad parameter, and probably --good 86 or similar, to make it go more quickly.

I've run it between this dates: [2021-04-08 - 2021-09-21] with pref browser.proton.doorhangers.enabled set to true
Push log: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=d64c1382f146846d7c1a1f399f195e3b9c5010d7&tochange=306a4c2820ef22db3b93132191c719371117c725

Just in case I've also run it between [2021-01-01 -- 2021-09-21]
Push Log: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=abe088b82e73b9859232c624a609d7dc1ead9fe1&tochange=29d477a1a826448e0f83846b69a326b89c5219bf

Let me know if there is something else that I can do it.

Comment 7

[:Gijs (he/him)]

(In reply to Marcela from comment #6)

Just in case I've also run it between [2021-01-01 -- 2021-09-21]
Push Log: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=abe088b82e73b9859232c624a609d7dc1ead9fe1&tochange=29d477a1a826448e0f83846b69a326b89c5219bf

Thanks! This points to bug 1697624 - it added this rule to browser/themes/shared/browser.inc.css :

+
+.popup-notification-body description,
+.popup-notification-body label,
+.popup-notification-body checkbox {
+  margin-inline-start: 0;
+}
+

which is setting margin-inline-start to 0 on the "Learn more" link, which it wasn't before.

Comment 8

[:Gijs (he/him)]

Attachment: Bug 1731494 - fix margins on learn more link in popupnotifications for extension controlled new tab, homepage and tab hiding, r?dao

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/54d3ed305aec
fix margins on learn more link in popupnotifications for extension controlled new tab, homepage and tab hiding, r=desktop-theme-reviewers,dao

Comment 10

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/54d3ed305aec

Comment 11

[Marco Castelluccio [:marco]]

Set release status flags based on info from the regressing bug 1697624

Comment 12

[Cristian Fogel [:cfogel]]

Confirmed issue with 94.0a1-20210919212908 on Win10.
Fix verified with 94.0b2 on Win10 and Ubuntu 16x32.

Comment 13

[Mihai Boldan, Desktop QA [:mboldan]]

Based on Comment 12, I'm marking this issue as Verified Fixed.

Comment 14

[Ryan VanderMeulen [:RyanVM]]

Did you want to nominate this for ESR uplift?

Comment 15

[:Gijs (he/him)]

Comment on attachment 9243674 [details]
Bug 1731494 - fix margins on learn more link in popupnotifications for extension controlled new tab, homepage and tab hiding, r?dao

ESR Uplift Approval Request

• If this is not a sec:{high,crit} bug, please state case for ESR consideration: user-visible style issue
• User impact if declined: see above
• Fix Landed on Version: 94
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): 1-line CSS-only fix
• String or UUID changes made by this patch: Nope

Comment 16

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9243674 [details]
Bug 1731494 - fix margins on learn more link in popupnotifications for extension controlled new tab, homepage and tab hiding, r?dao

Approved for 91.3esr.

Comment 17

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-esr91/rev/941660be8263

Comment 18

[Marcela (Please NI request to Brindusa Tot)]

Fix verified with 91.3.0esr on windows 10 and macOS 10.15.
I'll change flags accordingly.