1731520 - snap camera does not show video on firefox on mac

Status: RESOLVED FIXED

(Core :: WebRTC: Audio/Video, enhancement, P3)

Description

[saurabh.minni]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:92.0) Gecko/20100101 Firefox/92.0

Steps to reproduce:

Install Snap camera
Open any website which needs webcam access like meet.google.com
GIve permissions required to enable camera access to firefox and website

Actual results:

Nothing shown from camera to the webpage. Its just a black screen

Expected results:

Camera should capture and show the webcam content on the page

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Core::WebRTC: Audio/Video' component, and is moving the bug to that component. Please revert this change in case you think the bot is wrong.

Comment 2

[Nico Grunbaum [:ng, @chew:mozilla.org]]

Thanks for the bug report! Can you confirm that the Snap Camera device is usable in the macOS PhotoBooth app? If the answer is no, is it usable after a reboot?

Comment 3

[saurabh.minni]

SnapCamera is not usable in maxOS PhotoBooth app even after reboot.

SnapCamera though works for Chrome though, if that is helpful.

Comment 4

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

Confirmed. I'm going to guess this is blocked on bug 1451394. Andreas, do you agree?

Comment 5

[Andreas Pehrson [:pehrsons]]

Not necessarily. If we can port the chromium backend then yes. But if the backend comes from libwebrtc this is highly unclear.

Comment 6

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

FWIW I've also confirmed this works in Chrome but not Safari or Photobooth, using https://webrtc.github.io/samples/src/content/devices/input-output/

This seems consistent with information on Apple Developer Forums https://developer.apple.com/forums/thread/656944

Comment 7

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

Thanks, I'm going to mark it blocking on bug 1451394 since that bug captures that "We need to decide whether we want to continue using the webrtc.org". This lets us track it along other features like Full HD and 4K that are already blocking on it.

Comment 8

[Andreas Pehrson [:pehrsons]]

Snap Camera is reporting a bogus fourcc (ascii 0x18000000). It works in Chromium thanks to this which the libwebrtc backend does not do.

Comment 9

[Andreas Pehrson [:pehrsons]]

Scratch that. The libwebrtc backend configures the video output similarly to NV12 ('420v') as I've confirmed with logs. But it still calls didDropSampleBuffer for every frame. Unclear why.

Comment 10

[Andreas Pehrson [:pehrsons]]

If we provide width and height in videoSettings it works :s

Comment 11

[Andreas Pehrson [:pehrsons]]

Filed upstream: https://bugs.chromium.org/p/webrtc/issues/detail?id=14783

Comment 12

[Andreas Pehrson [:pehrsons]]

Attachment: Bug 1731520 - libwebrtc: Cherry-pick commit 7e176c41b9. r?ng!

Upstream commit: https://webrtc.googlesource.com/src/+/7e176c41b9818052d79d5e3065b36655edbebd6d
Get RTCCameraVideoCapturerTests working again

See commit
https://webrtc.googlesource.com/src/+/c8a6fb2bb8762de17008dee97c5fb6e762f7e056
where the setup methods for RTCCameraVideoCaptureTests' test cases were
lost. Both "setup" where XCTest instead looks for "setUp", and
"setupWithMockedCaptureSession" which isn't called explicitly anywhere.

This commit splits the old RTCCameraVideoCaptureTests into two;
RTCCameraVideoCaptureTests for tests using "setup", and
RTCCameraVideoCaptureTestsWithMockedCaptureSession for tests using
"setupWithMockedCaptureSession".

Bug: webrtc:8382
Change-Id: I64cefff744e12f62d65e04133512de1e10d17d95
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/288601
Reviewed-by: Kári Helgason <[e-mail]>
Reviewed-by: Daniel.L (Byoungchan) Lee <[e-mail]>
Commit-Queue: Kári Helgason <[e-mail]>
Cr-Commit-Position: refs/heads/main@{#38931}

Comment 13

[Andreas Pehrson [:pehrsons]]

Attachment: Bug 1731520 - libwebrtc: Cherry-pick commit 8ce2fc1448. r?ng!

Upstream commit: https://webrtc.googlesource.com/src/+/8ce2fc1448fb4d92480059957cb6c0b76896b59e
Add back lost RotationCamera tests

Lost in
https://webrtc.googlesource.com/src/+/c8a6fb2bb8762de17008dee97c5fb6e762f7e056

Bug: webrtc:8382
Change-Id: Ic9abd5d2b5d2593354e759c328b423ba272c8b9b
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/288700
Reviewed-by: Daniel.L (Byoungchan) Lee <[e-mail]>
Reviewed-by: Kári Helgason <[e-mail]>
Commit-Queue: Daniel.L (Byoungchan) Lee <[e-mail]>
Cr-Commit-Position: refs/heads/main@{#38991}

Comment 14

[Andreas Pehrson [:pehrsons]]

Attachment: Bug 1731520 - libwebrtc: Cherry-pick commit 8bec181bfc. r?ng!

Upstream commit: https://webrtc.googlesource.com/src/+/8bec181bfc4f3e3fee422513c0f75f90e80e4ed6
Finish converting RTCCameraVideoCapturerTests to XCTest

Failed gunit assertions in these XCTestCase classes cannot result in
failed tests.

Bug: webrtc:8382
Change-Id: I47b50b74f60029fafeff4ca885775482a85dfdd3
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/288603
Reviewed-by: Kári Helgason <[e-mail]>
Commit-Queue: Kári Helgason <[e-mail]>
Cr-Commit-Position: refs/heads/main@{#38995}

Comment 15

[Andreas Pehrson [:pehrsons]]

Attachment: Bug 1731520 - libwebrtc: Cherry-pick commit d100a589c8. r?ng!

Upstream commit: https://webrtc.googlesource.com/src/+/d100a589c82b57659d4ab8dba856fd68b21f1f40
Add dimensions to video settings in objc sdk camera backend.

This is required by some virtual cameras, like Snap Camera from
Snapchat.

Bug: webrtc:14783
Change-Id: I3d841936c17f3f227af9a94a4c3b0f37940d43b2
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/288361
Commit-Queue: Kári Helgason <[e-mail]>
Reviewed-by: Kári Helgason <[e-mail]>
Cr-Commit-Position: refs/heads/main@{#39073}

Comment 16

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fa7acbaa684f
libwebrtc: Cherry-pick commit 7e176c41b9. r=ng
https://hg.mozilla.org/integration/autoland/rev/5d8ab5be6952
libwebrtc: Cherry-pick commit 8ce2fc1448. r=ng
https://hg.mozilla.org/integration/autoland/rev/e94499837a0a
libwebrtc: Cherry-pick commit 8bec181bfc. r=ng
https://hg.mozilla.org/integration/autoland/rev/33f381f39f63
libwebrtc: Cherry-pick commit d100a589c8. r=ng

Comment 17

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/fa7acbaa684f
https://hg.mozilla.org/mozilla-central/rev/5d8ab5be6952
https://hg.mozilla.org/mozilla-central/rev/e94499837a0a
https://hg.mozilla.org/mozilla-central/rev/33f381f39f63