1731524 - Firefox 64-bit build on Linux is broken

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Zhenbo Li]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:94.0) Gecko/20100101 Firefox/94.0

Steps to reproduce:

Try to compile FIrefox on my Fedora 34 64-bit notebook

Actual results:

The build failed by

0:10.49 gmake[4]: *** No rule to make target '/home/lizhenbo/src/mozilla/mozilla-central/gfx/angle/checkout/src/compiler/translator/tree_ops/AddDefaultReturnStatements.cpp', needed by 'AddDefaultReturnStatements.o'. Stop.
0:10.49 gmake[3]: *** [/home/lizhenbo/src/mozilla/mozilla-central/config/recurse.mk:72: gfx/angle/targets/translator/target-objects] Error 2

Expected results:

I made a git bisect on about 1.8k commits.

5d9ba6c221a57a50550f4c15bdff26b43056fad8 is the first bad commit
commit 5d9ba6c221a57a50550f4c15bdff26b43056fad8
Author: Jeff Gilbert <[e-mail]>
Date: Thu Sep 16 18:24:29 2021 +0000

Bug 1717151 - Vendor angle/chromium/4515 with fixes. r=gfx-reviewers,lsalzman

Differential Revision: https://phabricator.services.mozilla.com/D125747

Its parent commit can be compiled on my notebook with the same config

commit 6dcd4b1e5e482f4b8cf0e5ce4e621423c88ffcdb
Author: Jeff Gilbert <[e-mail]>
Date: Thu Sep 16 18:24:28 2021 +0000

Bug 1717151 - Prep ANGLE for vendoring. r=gfx-reviewers,kvark

Differential Revision: https://phabricator.services.mozilla.com/D125746

Comment 1

[Zhenbo Li]

Providing hg link

This is the last version can be built by me: https://hg.mozilla.org/mozilla-unified/rev/a74a2d43142573f641bc22ed2bbc5fd85b3700fd

This is the first broken version on my laptop: https://hg.mozilla.org/mozilla-unified/rev/63c5cd4757d5a219dc36af02e606dbb737692edd

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Firefox Build System::General' component, and is moving the bug to that component. Please revert this change in case you think the bot is wrong.

Comment 3

[Mitchell Hentges [:mhentges] 🦀]

I'm not able to reproduce this on my Fedora 34 64-bit machine.
Are you working outside the sysroot? Can you share your:

• mozconfig, if you have one
• $objdir/config.status?

Also, are you able to reproduce the failure on:

• central/29d6504debf5b2028a9da65026ae86a06b5a655d
• On a clean build (e.g.: after a ./mach clobber)?

Comment 4

[Sylvestre Ledru [:Sylvestre]]

We should add bug 1717151 in the CLOBBER file

Julien just had the same issue

Comment 6

[Mike Hommey [:glandium]]

Bug 1717151 moved AddDefaultReturnStatements.cpp from gfx/angle/checkout/src/compiler/translator/tree_ops to gfx/angle/checkout/src/compiler/translator/tree_ops/d3d, and the build system doesn't handle file moves when they're referenced from the same moz.build.

A manual clobber works around the problem.

Comment 7

[Zhenbo Li]

Attachment: mozconfig

Comment 8

[Zhenbo Li]

Attachment: obj-x86_64-pc-linux-gnu/config.status

Comment 9

[Zhenbo Li]

1. I executed $ ./mach build and the build failed as expected. mozconfig and config.status attached.
2. $ ./mach clobber
3. $ ./mach build succeeded

Comment 10

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1717151

Comment 11

[Mitchell Hentges [:mhentges] 🦀]

Attachment: Bug 1731524: Updating ANGLE requires a clobber

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9595253d2006
Updating ANGLE requires a clobber r=jgilbert

Comment 13

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/9595253d2006

Comment 14

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-esr91/rev/eb88e94e38c6