1731538 - New DuckDuckGo 16x16 search icon is blurry compared with site favicon

Status: VERIFIED FIXED

(Firefox :: Address Bar, defect)

Description

[Kestrel]

Attachment: Blurry search engine icon

STR:

1. Use 100% scaling (96 DPI).
2. Visit https://duckduckgo.com.
3. Compare the tab favicon with the new DuckDuckGo search icon in the address bar.

The duck's eyes should be dark and sharply defined but the new search icon is blurry.

Regressed by Bug 1730070.

Comment 1

[Pascal Chevrel:pascalc (PTO until April 26)]

Daisuke, can you look at this please? We probably need to uplift a fix for this icon to all our active branches. Thanks.

Comment 2

[Daisuke Akatsuka (:daisuke)]

Thanks. I will fix it soon.

Comment 3

[Daisuke Akatsuka (:daisuke)]

Attachment: Bug 1731538: Replace ddg favicon with a clearer one.

Comment 4

[Ryan VanderMeulen [:RyanVM]]

This won't make the 92.0.1 dot release, but I think we can live with the blurrier version for a week or so until 93 ships.

Comment 5

[Pascal Chevrel:pascalc (PTO until April 26)]

This is not going to make our last beta. We build our Release Candidate on Monday.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cc31ac4676e7
Replace ddg favicon with a clearer one. r=adw

Comment 7

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/cc31ac4676e7

Comment 8

[Daisuke Akatsuka (:daisuke)]

Should we request for uplift for beta??

Comment 9

[Pascal Chevrel:pascalc (PTO until April 26)]

Please request the uplift asap, we build our RC today, thanks.

Comment 10

[Daisuke Akatsuka (:daisuke)]

Okay, thanks!

Comment 11

[Daisuke Akatsuka (:daisuke)]

Comment on attachment 9242382 [details]
Bug 1731538: Replace ddg favicon with a clearer one.

Beta/Release Uplift Approval Request

• User impact if declined: User can't see proper DDG icon image.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This change just replace DDG image with proper one.
• String changes made/needed: None

Comment 12

[Pascal Chevrel:pascalc (PTO until April 26)]

Comment on attachment 9242382 [details]
Bug 1731538: Replace ddg favicon with a clearer one.

Low risk icon swap, approved for the beta branch before the merge, thanks.

Comment 13

[Pascal Chevrel:pascalc (PTO until April 26)]

https://hg.mozilla.org/releases/mozilla-beta/rev/4b995fe79ff1

Comment 14

[Pascal Chevrel:pascalc (PTO until April 26)]

https://hg.mozilla.org/releases/mozilla-esr78/rev/e870cc41d207

Comment 15

[Pascal Chevrel:pascalc (PTO until April 26)]

https://hg.mozilla.org/releases/mozilla-esr91/rev/c6d088a7eae3

Comment 16

[Cristian Comorasu, QA [:ccomorasu], Releae Desktop QA - Please contact [e-mail]]

I reproduced this issue using Fx 92.0.1 on Ubuntu 20.04 LTS.
I verified this fix on Windows 10 x64, Ubuntu 20.04 LTS and macOS 10.13 using Fx 78.14.0esr, Fx 91.1.0esr, Fx 93.0 and Fx 94.0a1.