1731555 - Baseline: Add some test cases, remove redundant return values, tidy up

Status: RESOLVED FIXED

(Core :: JavaScript: WebAssembly, enhancement, P3)

Description

[Lars T Hansen [:lth]]

This is some generic cleanup that has accumulated during the wasm64 work but is not directly related to it:

• some test cases were missing
• a test case contained a spurious print
• lots of baseline functions always returned true, and need not return anything
• methods in the compiler were not grouped meaningfully

Comment 1

[Lars T Hansen [:lth]]

Attachment: Bug 1731555 - Misc wasm cleanup. r?yury

Tidy up some things in anticipation of the wasm64 work:

• some test cases were missing
• a test case contained a spurious print
• lots of baseline functions always returned true, and need not return anything
• methods in the baseline compiler were not grouped meaningfully
• methods in WasmInstance.cpp were not grouped meaningfully

More could be done, but this removes much of the noise from the wasm64
patches, at least.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/480178ad0397
Misc wasm cleanup. r=yury

Comment 3

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/480178ad0397