1731587 - [sanitizer] implement comments handling, remove string api & adjust exceptions to match wpt

Status: RESOLVED FIXED

(Core :: DOM: Security, enhancement, P1)

Comment 1

[Frederik Braun [:freddy]]

Attachment: Bug 1731587 - [sanitizer] Remove string-based APIs, handle HTML comments, align exceptions with wpt r?hsivonen

This patch combines three relatively small changes:

1. Removing string-based APIs
   -- Adjusting the Sanitize() function, its WebIDl definition etc. to only
   accept Document/DocumentFragment
2. Parse allowComments from the Sanitizer constructor and pass into the
   underlying nsTreeSanitizer
3. Ensure that exceptions and error cases align with current wpt

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/891f007ad684
[sanitizer] Remove string-based APIs, handle HTML comments, align exceptions with wpt r=hsivonen

Comment 3

[Alexandru Michis [:malexandru]]

Backed out changeset 891f007ad684 (Bug 1731587) for causing mochitest plain failures in mochitest/test_sanitizer_api.html
Backout link: https://hg.mozilla.org/integration/autoland/rev/b1d30f0415a442a17cd96f891530ce78f325377f
Push with failures, failure log.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0b2dfad8e6c5
[sanitizer] Remove string-based APIs, handle HTML comments, align exceptions with wpt r=hsivonen

Comment 5

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/31088 for changes under testing/web-platform/tests

Comment 6

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot

Comment 7

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/0b2dfad8e6c5