Closed Bug 1731595 Opened 3 years ago Closed 3 years ago

[Rust SDK] Calling persist_ping_lifetime_data() after shutdown() panics

Categories

(Data Platform and Tools :: Glean: SDK, defect, P1)

Product:
Data Platform and Tools
Component:
Glean: SDK
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: chutten, Assigned: janerik)

References

Details

Attachments

(1 file)

Link to GitHub pull-request: https://github.com/mozilla/glean/pull/1800
42 bytes, text/x-github-pull-request
Details | Review

If, on the Rust Glean SDK's public API, you call persist_ping_lifetime_data() after calling shutdown(), it panics.

I think a minimum-effort fix would be to document this on the APIs.

Though I also think we can probably with small effort make it so it doesn't panic, and write a test to ensure it.

Assignee: nobody → jrediger
Priority: -- → P1

badboy merged PR #1800: "Bug 1731595 - Avoid a panic when trying to persist ping-lifetime data after shutdown" in c7c520f.

Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: