Closed Bug 1731635 Opened 3 years ago Closed 3 months ago

Add a setting to disable split console

Categories

(DevTools :: Console, enhancement, P3)

Firefox 92
enhancement

Tracking

(relnote-firefox 126+, firefox126 fixed)

RESOLVED FIXED
126 Branch
Tracking Status
relnote-firefox --- 126+
firefox126 --- fixed

People

(Reporter: olaf223224, Assigned: artemmanusenkov, Mentored)

References

(Regressed 2 open bugs)

Details

(Keywords: dev-doc-complete)

Attachments

(2 files)

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:92.0) Gecko/20100101 Firefox/92.0

Steps to reproduce:

  1. Set devtools.command-button-splitconsole.enabled and devtools.toolbox.splitconsoleEnabled to false
  2. Open the web console by pressing f12
  3. Press escape

Actual results:

The split console opened up

Expected results:

Nothing

The Bugbug bot thinks this bug should belong to the 'DevTools::Console' component, and is moving the bug to that component. Please revert this change in case you think the bot is wrong.

Component: Untriaged → Console
Product: Firefox → DevTools

I don't think there's a way to disable the split console at the moment

  • devtools.command-button-splitconsole.enabled doesn't seem to be used
  • devtools.toolbox.splitconsoleEnabled stores the state of the split console (so we reopen it at startup if it was open in the previous session)

why do you want to disable it?

Flags: needinfo?(olaf223224)

It's annoying to have the console pop up when I press esc (which is used for all sorts of other things). Previously, I swear it was working and I was able to turn it off. I suspect something may have changed in a recent update?

Flags: needinfo?(olaf223224)
Type: defect → enhancement
Summary: Cannot disable split console → Add a setting to disable split console

(In reply to Nicolas Chevobbe [:nchevobbe] from comment #2)

why do you want to disable it?

In my case, I want to disable the split console because I have poor eyesight, and at any comfortable zoom level, there just isn't room on the screen for it, even with the devtools in a detached, maximized window on a 27" monitor. Any time I do something that makes it open (for example, right-click on an element in the Inspector tab and "Use in Console") the screen becomes an unusable mess of squashed panels, and I have to manually close the split console and switch to the Console tab.

Automatically switching to the full Console tab would be a bonus, but just blocking the split console from opening would be a big help.

I don't want splitconsole! The "Open in Console" button, etc. buttons, should open the normal Console panel, not splitconsole.

I want an option that changes the action of the "Open in Console" etc buttons.

Whiteboard: [devtools-triage]
Mentor: nchevobbe
Status: UNCONFIRMED → NEW
Ever confirmed: true
Priority: -- → P3
Whiteboard: [devtools-triage]

Hello, I would Like to work on this. Can this be assigned to me?

Flags: needinfo?(nchevobbe)

devtools.command-button-splitconsole.enabled can be used to disable the Split conole in Devtools

Assignee: nobody → abhijeetchawla22
Status: NEW → ASSIGNED

Thanks! It was assigned when you pushed your patch to phabricator

Flags: needinfo?(nchevobbe)
Attachment #9323193 - Attachment description: Bug 1731635 Disable Split console in Devtools r=nchevobbe → Bug 1731635 Disable Split console shortcut in Devtools r=nchevobbe
Attachment #9323193 - Attachment description: Bug 1731635 Disable Split console shortcut in Devtools r=nchevobbe → Bug 1731635 Disable Split console in Devtools r=nchevobbe

Looking at a comment in the patch and the comments here, there seem to be two overlapping use cases:

  1. Disable the Split Console completely
    I.e. the Escape key does nothing, the different menu options that usually open the Split Console will open the normal Web Console and the entry from the global menu (aka meatball menu) is removed.
  2. Stop the Escape key from opening the Split Console but keep the Split Console active
    I.e. the Escape key does nothing but the Split Console is still opened when from the different menu options and can be opened via the global menu.

I think the former should be covered by this bug. The latter is covered by bug 972662 or bug 1116951, which are meant to allow customizing (and removing) the key bindings of the DevTools.

Sebastian

See Also: → 1116951

The bug assignee is inactive on Bugzilla, so the assignee is being reset.

Assignee: abhijeet.chawla.18 → nobody
Status: ASSIGNED → NEW

the different menu options that usually open the Split Console will open the normal Web Console and the entry from the global menu (aka meatball menu) is removed

This is what I want, for what it's worth. I find the "use in console" option really frustrating to use on 16:9 laptop screens because it forces open the split console rather than opening the console tab.

I know nothing about Firefox internals, but it seems possible that I could take what's already been written and push it over the line if I can be pointed in the right direction. It's not clear to me exactly what still needs to be done from reading the Phabricator.

I'll take up the torch!

Assignee: nobody → artemmanusenkov
Status: NEW → ASSIGNED
Pushed by nchevobbe@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/622bd9520170
[devtools] Add option to disable split console r=nchevobbe,fluent-reviewers,devtools-reviewers,bolsson
Regressions: 1888080
Status: ASSIGNED → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → 126 Branch

Artem, could you consider nominating this for a release note? If you want to mention it (Process info)
We could include it in the nightly release notes.

Flags: needinfo?(artemmanusenkov)

Release Note Request
[Why is this notable]: Added an option to disable split console. After disabling it the escape key won't trigger the split console; "use in console" and error counter toolbox button will open the console tab instead.
[Affects Firefox for Android]: none
[Suggested wording]: added an option to disable/enable the devtools split console feature
[Links (documentation, blog post, etc)]:

relnote-firefox: --- → ?
Flags: needinfo?(artemmanusenkov)
Keywords: dev-doc-needed
Regressions: 1888298

Thanks, added to the Fx126 nightly release notes, please allow 30 minutes for the site to update.
Keeping the relnote-firefox flag as ? to keep it on the radar for inclusion in the final Fx126 release notes.

About the dev-doc-needed keyword added here, I was wondering if you're planning to submit a PR for this update on mdn/content, to be published in the Firefox 126 release notes on MDN? I'm asking because Nicolas opened a PR for a DevTools release note update in a previous release.

FYI - I have an issue open to track this update: https://github.com/mdn/content/issues/33179.

Flags: needinfo?(artemmanusenkov)

I wasn't planning to submit it, i didn't know it existed. but it seems like a good idea to have it added to those release notes too. i'll take a couple days to submit the PR to mdn/content since i'm a bit busy

i had these in mind when i added the keyword
https://firefox-source-docs.mozilla.org/devtools-user/web_console/split_console/index.html
https://firefox-source-docs.mozilla.org/devtools-user/settings/index.html

@dbhattacharya@mozilla.com

Flags: needinfo?(artemmanusenkov)
See Also: → 1893982

Thank you artemmanusenkov@gmail.com for opening the PR!

You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: