Closed
Bug 1731636
Opened 4 years ago
Closed 4 years ago
Guard against failed BufferData when loading vertex attributes in SWGL
Categories
(Core :: Graphics: WebRender, enhancement)
Core
Graphics: WebRender
Tracking
()
RESOLVED
FIXED
94 Branch
| Tracking | Status | |
|---|---|---|
| firefox94 | --- | fixed |
People
(Reporter: lsalzman, Assigned: lsalzman)
References
(Depends on 1 open bug)
Details
Attachments
(1 file)
If BufferData calls fail due to OOM, we might accidentally try to load from an enabled vertex attribute that feeds off that invalid buffer. We need to check to ensure that the backing buffer successfully allocated, even if the vertex attribute was enabled, before trying to load from it.
|
Assignee | |
Updated•4 years ago
|
Depends on: sw-wr-stability
|
|
Assignee | |
Comment 1•4 years ago
|
||
|
|
Assignee | |
Comment 2•4 years ago
|
||
This could be a possible explanation for bug 1689978.
See Also: → 1689978
Pushed by lsalzman@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c4489073fbd5
Guard against failed BufferData when loading vertex attributes in SWGL. r=nical
|
||
Comment 4•4 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox94:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 94 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•