1731665 - Land tests for hiding form validationMessage in response to window.open

Status: RESOLVED FIXED

(Toolkit :: UI Widgets, task, P1)

Description

[:Gijs (he/him)]

+++ This bug was initially created as a clone of Bug #1726621 +++

Landing tests separately to avoid blocking the other bug which is tracking 93, and to avoid having tests show up in the tree at the same time.

Comment 1

[:Gijs (he/him)]

Attachment: Bug 1731665 - tests, r?NeilDeakin

Comment 2

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

tests, r=NeilDeakin
https://hg.mozilla.org/integration/autoland/rev/0ebc4402a7cb4826e0ee4299e354dcbedb418baf
https://hg.mozilla.org/mozilla-central/rev/0ebc4402a7cb

Comment 3

[Ryan VanderMeulen [:RyanVM]]

It's a bit surprising to me that this landed before 93 shipped to users.

Comment 4

[:Gijs (he/him)]

(In reply to Ryan VanderMeulen [:RyanVM] from comment #3)

It's a bit surprising to me that this landed before 93 shipped to users.

The original bug was a sec moderate, so I thought we didn't need to wait; in fact in a different but related bug's patch, https://phabricator.services.mozilla.com/D122785#3992391 I was explicitly asked not to obfuscate or land tests separately; the only reason I landed it separately here is because there was still some uncertainty around the specifics of the test and making sure it accurately tested whether things broke, and I didn't want to block landing the fix on that.

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-esr91/rev/ebfc9cc72d39