1731790 - Add blank implementation of Fetch.disable to prevent unknown method errors

Status: RESOLVED FIXED

(Remote Protocol :: CDP, task, P2)

Description

[Henrik Skupin [:whimboo][⌚️UTC+2]]

As chatted with Simon this method is needed by Selenium so that a new CDP session can be established. By just adding a blank method for Fetch.disable we could get support for CDP by Selenium.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Attachment: Bug 1731790 - [cdp] Add blank implementation of Fetch.disable to prevent unknown method errors.

Depends on D126231

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1a7ec672c576
[cdp] Add blank implementation of Fetch.disable to prevent unknown method errors. r=webdriver-reviewers,jdescottes

Comment 3

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/1a7ec672c576

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Comment on attachment 9242410 [details]
Bug 1731790 - [cdp] Add blank implementation of Fetch.disable to prevent unknown method errors.

Beta/Release Uplift Approval Request

• User impact if declined: Uplifting the new feature to the current beta would help Selenium developers to better get CDP support added for Firefox to the Java bindings, and to release it earlier.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Just a blank implementation of the API end-point to not cause a not supported command error.
• String changes made/needed:

Comment 5

[Pascal Chevrel:pascalc]

Comment on attachment 9242410 [details]
Bug 1731790 - [cdp] Add blank implementation of Fetch.disable to prevent unknown method errors.

We have already merged and build our release candidate, mozilla-release is now set to 93 and 94 beta 1 ships next Tuesday.