Simply "./mach python" options
Categories
(Firefox Build System :: Mach Core, task)
Tracking
(firefox96 fixed)
| Tracking | Status | |
|---|---|---|
| firefox96 | --- | fixed |
People
(Reporter: mhentges, Assigned: mhentges)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
Additional details in this comment.
--no-virtualenvis obsolete (was needed forget_and_diffoscopetask in the past, but no longer). Remove it.--no-activateis a stand-in for supporting the "get native python packages from system python" use case, which is obsolete.--requirementsis only used to download and installpsutil: replace this with a--virtualenvargument that uses a centralized virtualenv. Use themachvirtualenv by default.
This will avoid an unnecessary common virtualenv activation in many cases, which will make the virtualenv=>virtualenv activation-compatibility check fail in less cases.
|
Assignee | |
Updated•3 years ago
|
|
|
Assignee | |
Comment 1•3 years ago
|
||
--no-virtualenv was only needed for the get_and_diffoscope task
because we used to build and install psutil (from vendored source)
into new virtualenvs.
However, the get_and_diffoscope task didn't need psutil, and it
didn't have the environment needed to build the native psutil package.
Since we no longer build and install psutil into every virtualenv,
it's no longer needed for its one usage, which means that it can be
removed.
--requirements is replaced by --virtualenv, which removes an
ad-hoc pip package installation and embraces the centralized dep
system further.
--no-activate is now implied by default: ./mach python always
runs in a Mach-compatible environment (including sys.path additions),
but the common virtualenv is no longer activated by default. This
is good because it allows ./mach subprocesses (as there are in
CI, with ./mach python <script-that-calls-mach>). The only potential
downside is that ./mach python scripts implicitly pip install-ing
packages will now fail unless they specify a virtualenv, because
ad-hoc installations into the Mach virtualenv are, as of recently,
forbidden.
ipython==7.16.1 was the chosen version because it is the last
one compatible with Python 3.6.
Depends on D120397
|
||
Updated•3 years ago
|
|
|
||
Updated•3 years ago
|
Pushed by mhentges@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/310c4d50978e Simplify `./mach python` arguments r=ahal
|
||
Comment 3•3 years ago
|
||
| bugherder | ||
Description
•