Closed
Bug 1731838
Opened 3 years ago
Closed 3 years ago
Don't allow "pip install" when Mach venv/system Python is active
Categories
(Firefox Build System :: Mach Core, enhancement)
Firefox Build System
Mach Core
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: mhentges, Assigned: mhentges)
References
(Blocks 1 open bug)
Details
Eventually, we don't want any ad-hoc pip packages installed.
However, a first step is throwing up some guards against installing in the system Python environment or the Mach virtualenv.
Add checks accordingly to install_pip_package and install_pip_requirements.
In the future, when all commands are fully embracing the centralized dependency system, we can remove all remaining ad-hoc pip install usages.
|
Assignee | |
Updated•3 years ago
|
Assignee: nobody → mhentges
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 1•3 years ago
|
||
This is fixed because MachSiteManager no longer has install_pip_package() functionality - only "command" sites can do that now.
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•