1732014 - [wpt-sync] Sync PR 30827 - [SelectMenu] Apply controller code to the author provided shadow DOM.

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 30827 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/30827
Details from upstream follow.

Ionel Popescu <[e-mail]> wrote:

[SelectMenu] Apply controller code to the author provided shadow DOM.

This change ensure that controller code is applied to the author
provided shadow DOM by having the mutation observer watch
changes for the shadow root.

Because of that we can't rely on the slotchange event to catch
when the default parts were replaced as we would have duplicate
notifications. In order to do that
HTMLSelectMenuElement::SelectMutationCallback should be extended to
handle the case when a node with slot attribute is inserted/removed
even if its part attribute isn't set.

Bug: 1121840
Change-Id: I20ec7a00b8a3a130740a4dc0354bba0563ebb0a1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3166023
Reviewed-by: Dan Clark \<[e-mail]>
Reviewed-by: Mason Freed \<[e-mail]>
Commit-Queue: Ionel Popescu \<[e-mail]>
Cr-Commit-Position: refs/heads/main@{#922716}

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

PR 30827 applied with additional changes from upstream: bf25d97a5e9b59c0f54e31936f6c0bbcde12f319

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=be21b27d470f59a9c81e2ebcc3d657ea13cbdb40

Comment 3

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 7 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 2 tests and 3 subtests

Status Summary

Firefox

OK : 2
FAIL : 7

Chrome

OK : 2
PASS : 5
FAIL : 2

Safari

OK : 1
FAIL : 3
ERROR: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/html/semantics/forms/the-selectmenu-element/selectmenu-popup.tentative.html
Opening the popup and clicking an option should change the selectmenu's value: FAIL (Chrome: PASS)
With custom button and popup: opening the popup and clicking an option should change the selectmenu's value: FAIL (Chrome: PASS)
Clicking a popup with no listbox part does nothing: FAIL (Chrome: PASS)
Clicking a popup with a listbox that was removed does nothing: FAIL (Chrome: PASS)
/html/semantics/forms/the-selectmenu-element/selectmenu-shadow-root-replacement.tentative.html
Test that the UA provided shadow root can be replaced: FAIL (Chrome: FAIL, Safari: FAIL)
Test that the UA provided shadow root can be replaced using declarative shadow DOM: FAIL (Chrome: PASS, Safari: FAIL)
Test that only the UA provided shadow root can be replaced: FAIL (Chrome: FAIL, Safari: FAIL)

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a91195879163
[wpt PR 30827] - [SelectMenu] Apply controller code to the author provided shadow DOM., a=testonly
https://hg.mozilla.org/integration/autoland/rev/c520d326d168
[wpt PR 30827] - Update wpt metadata, a=testonly

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7e0129b5d9c9
[wpt PR 30827] - [SelectMenu] Apply controller code to the author provided shadow DOM., a=testonly
https://hg.mozilla.org/integration/autoland/rev/6eb51a2ad47c
[wpt PR 30827] - Update wpt metadata, a=testonly

Comment 6

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/7e0129b5d9c9
https://hg.mozilla.org/mozilla-central/rev/6eb51a2ad47c