Closed Bug 1732037 Opened 4 years ago Closed 4 years ago

[wpt-sync] Sync PR 30829 - [LayoutNG] Fieldset overflow clip and fragmentation

Categories

(Core :: Layout, task, P4)

task

Tracking

()

RESOLVED FIXED
95 Branch
Tracking Status
firefox95 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 30829 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/30829
Details from upstream follow.

Alison Maher <almaher@microsoft.com> wrote:

[LayoutNG] Fieldset overflow clip and fragmentation

If fieldset content exceeded the max block-size due to fragmentation,
we would fail to clip the content correctly (see
overflow-clip-012.html). As a follow-up to CL:2556877 and CL:3141939,
this CL fixes the issue by doing a normal (non-measuring) layout
first, and then relaying out with the max block-size constraint if
the initial result's block size (+ consumed block-size from previous
fragments) exceeded the max.

Bug: 1249489
Change-Id: I8e21f4beb02c631ec677a1967f9867e7fe36d670
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3166172
Commit-Queue: Alison Maher \<almaher@microsoft.com>
Reviewed-by: Morten Stenshorne \<mstensho@chromium.org>
Cr-Commit-Position: refs/heads/main@{#923146}

Component: web-platform-tests → Layout
Product: Testing → Core

CI Results

Ran 7 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 2 tests

Status Summary

Firefox

PASS: 2

Chrome

PASS: 2

Safari

PASS: 2

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/ebf60969a487 [wpt PR 30829] - [LayoutNG] Fieldset overflow clip and fragmentation, a=testonly
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/f8d2268171d7 [wpt PR 30829] - [LayoutNG] Fieldset overflow clip and fragmentation, a=testonly
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 95 Branch
You need to log in before you can comment on or make changes to this bug.