1732038 - [wpt-sync] Sync PR 30837 - [@layer] Fix cascade ordering of inline style and layered style

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 30837 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/30837
Details from upstream follow.

Xiaocheng Hu <[e-mail]> wrote:

[@layer] Fix cascade ordering of inline style and layered style

This patch adds a new flag to MatchResult and CascadePriority to
indicate if a declaration is from inline style or other style sheets, so
that we can compare inline style and other layered style correctly.

Without this flag, currently we are treating inline style as regular
declarations in the implicit outer layer, and therefore mistakenly
override it with layered style rules in other style sheets.

Bug: 1095765
Change-Id: I10dbafcf9721fc5b8a5b11edeaeab48c82df86d4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3167095
Commit-Queue: Xiaocheng Hu \<[e-mail]>
Reviewed-by: Rune Lillesveen \<[e-mail]>
Reviewed-by: Anders Hartvoll Ruud \<[e-mail]>
Cr-Commit-Position: refs/heads/main@{#923216}

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=86f6c663999f103a07c8f4a89b59d3a8a20c6f75

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 7 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 2 tests and 2 subtests

Status Summary

Firefox

OK : 2
PASS: 6

Chrome

OK : 2
PASS: 5
FAIL: 1

Safari

OK : 2
PASS: 5
FAIL: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/448715b83303
[wpt PR 30837] - [@layer] Fix cascade ordering of inline style and layered style, a=testonly

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6f7ebd034fb3
[wpt PR 30837] - [@layer] Fix cascade ordering of inline style and layered style, a=testonly

Comment 5

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/6f7ebd034fb3