1732053 - Dialog abuse detection is no longer reset after reloading a page

Status: RESOLVED WONTFIX

(Core :: DOM: Core & HTML, defect)

Description

[Julian Descottes [:jdescottes]]

STRs

• open any page (eg https://www.wikipedia.org/)
• trigger an alert (eg via DevTools console: window.alert(1))
• reload the page and trigger an alert again (do it quickly, under 3 seconds)

Before Bug 1646532, we would display a regular alert. After Bug 1646532, we display an alert with the checkbox related to dialog abuse detection ("Don't allow ... to prompt you again").

We spotted this via Bug 1731795, because Marionette is not handling such alerts properly and this makes the Selenium test suite fail.

I am only filing a bug in case this is an unexpected modification. I haven't seen this behavior change explicitly called out in Bug 1646532. If the new behavior is intended and/or correct, feel free to close this.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1646532

Comment 2

[Anny Gakhokidze [:annyG]]

When I landed my patch, we did intend this behaviour. However, since there is an argument to be made for either case, I'm going to NI Johann to make the final decision.

Johann, in bug 1646532 I was trying to rewrite the dialog abuse detecting code to make it fission compatible, and we decided to move dialog abuse detecting fields to the browsing context group instead of the browsing contexts to avoid cross-process syncing. The result is that that dialog abuse detection tracking no longer happens on window basis, bur rather on the browsing context group basis. Are you okay with keeping this behaviour or should we revert back to the previous behaviour? This behaviour is more conservative in terms of allowing dialogs to show up for the user. Thanks in advance!

Comment 3

[Johann Hofmann [:johannh]]

So this didn't survive location.reload() before? Yeah, I'm okay with that new behavior :)