[wpt-sync] Sync PR 30872 - Improve numerical robustness of scroll-animation-effect-phases.tentative.html
Categories
(Testing :: web-platform-tests, task, P4)
Tracking
(firefox95 fixed)
| Tracking | Status | |
|---|---|---|
| firefox95 | --- | fixed |
People
(Reporter: wpt-sync, Unassigned)
References
()
Details
(Whiteboard: [wptsync downstream])
Sync web-platform-tests PR 30872 into mozilla-central (this bug is closed when the sync is complete).
PR: https://github.com/web-platform-tests/wpt/pull/30872
Details from upstream follow.
Kevin Ellis <kevers@chromium.org> wrote:
Improve numerical robustness of scroll-animation-effect-phases.tentative.html
This patch improved numerical stability by ensuring that all expected
values are well conditioned. With the changes, all timeline times and
current times are integer percentages.Bug: 1246372
Change-Id: I9998826a0d4a58aa21e7aad68932e80a79707d1f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3169158
Commit-Queue: Kevin Ellis \<kevers@chromium.org>
Reviewed-by: Jordan Taylor \<jortaylo@microsoft.com>
Cr-Commit-Position: refs/heads/main@{#923378}
|
Assignee | |
Comment 1•4 years ago
|
||
|
|
Assignee | |
Comment 2•4 years ago
|
||
|
|
Assignee | |
Comment 3•4 years ago
|
||
CI Results
Ran 7 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI
Total 1 tests and 61 subtests
Status Summary
Firefox
OK : 1
FAIL: 61
Chrome
OK : 1
PASS: 61
Safari
OK : 1
FAIL: 61
Links
Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base
Details
New Tests That Don't Pass
/scroll-animations/scroll-animation-effect-phases.tentative.html: OK [GitHub], SKIP [Gecko-android-em-7.0-x86_64-lite-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-linux1804-64-tsan-qr-opt] (Chrome: OK, Safari: OK)
Current times and effect phase before timeline start when delay = 0 and endDelay = 0 |: FAIL (Chrome: PASS, Safari: FAIL)
Current times and effect phase at timeline start when delay = 0 and endDelay = 0 |: FAIL (Chrome: PASS, Safari: FAIL)
Current times and effect phase in timeline range when delay = 0 and endDelay = 0 |: FAIL (Chrome: PASS, Safari: FAIL)
Current times and effect phase at timeline end when delay = 0 and endDelay = 0 |: FAIL (Chrome: PASS, Safari: FAIL)
Current times and effect phase after timeline end when delay = 0 and endDelay = 0 |: FAIL (Chrome: PASS, Safari: FAIL)
Current times and effect phase before timeline start when delay = 500 and endDelay = 0 |: FAIL (Chrome: PASS, Safari: FAIL)
Current times and effect phase at timeline start when delay = 500 and endDelay = 0 |: FAIL (Chrome: PASS, Safari: FAIL)
Current times and effect phase before effect delay when delay = 500 and endDelay = 0 |: FAIL (Chrome: PASS, Safari: FAIL)
Current times and effect phase at effect start when delay = 500 and endDelay = 0 |: FAIL (Chrome: PASS, Safari: FAIL)
Current times and effect phase in timeline range when delay = 500 and endDelay = 0 |: FAIL (Chrome: PASS, Safari: FAIL)
Current times and effect phase at timeline end when delay = 500 and endDelay = 0 |: FAIL (Chrome: PASS, Safari: FAIL)
Current times and effect phase after timeline end when delay = 500 and endDelay = 0 |: FAIL (Chrome: PASS, Safari: FAIL)
Current times and effect phase before timeline start when delay = -250 and endDelay = 0 |: FAIL (Chrome: PASS, Safari: FAIL)
Current times and effect phase at timeline start when delay = -250 and endDelay = 0 |: FAIL (Chrome: PASS, Safari: FAIL)
Current times and effect phase in timeline range when delay = -250 and endDelay = 0 |: FAIL (Chrome: PASS, Safari: FAIL)
Current times and effect phase at timeline end when delay = -250 and endDelay = 0 |: FAIL (Chrome: PASS, Safari: FAIL)
Current times and effect phase after timeline end when delay = -250 and endDelay = 0 |: FAIL (Chrome: PASS, Safari: FAIL)
Current times and effect phase before timeline start when delay = 0 and endDelay = -250 |: FAIL (Chrome: PASS, Safari: FAIL)
Current times and effect phase at timeline start when delay = 0 and endDelay = -250 |: FAIL (Chrome: PASS, Safari: FAIL)
Current times and effect phase in timeline range when delay = 0 and endDelay = -250 |: FAIL (Chrome: PASS, Safari: FAIL)
Current times and effect phase at timeline end when delay = 0 and endDelay = -250 |: FAIL (Chrome: PASS, Safari: FAIL)
Current times and effect phase after timeline end when delay = 0 and endDelay = -250 |: FAIL (Chrome: PASS, Safari: FAIL)
Current times and effect phase before timeline start when delay = 0 and endDelay = 500 |: FAIL (Chrome: PASS, Safari: FAIL)
Current times and effect phase at timeline start when delay = 0 and endDelay = 500 |: FAIL (Chrome: PASS, Safari: FAIL)
Current times and effect phase in timeline range when delay = 0 and endDelay = 500 |: FAIL (Chrome: PASS, Safari: FAIL)
Current times and effect phase at effect end when delay = 0 and endDelay = 500 |: FAIL (Chrome: PASS, Safari: FAIL)
Current times and effect phase after effect endDelay when delay = 0 and endDelay = 500 |: FAIL (Chrome: PASS, Safari: FAIL)
Current times and effect phase at timeline end when delay = 0 and endDelay = 500 |: FAIL (Chrome: PASS, Safari: FAIL)
Current times and effect phase after timeline end when delay = 0 and endDelay = 500 |: FAIL (Chrome: PASS, Safari: FAIL)
Current times and effect phase before timeline start when delay = 375 and endDelay = 375 |: FAIL (Chrome: PASS, Safari: FAIL)
Current times and effect phase at timeline start when delay = 375 and endDelay = 375 |: FAIL (Chrome: PASS, Safari: FAIL)
Current times and effect phase before effect delay when delay = 375 and endDelay = 375 |: FAIL (Chrome: PASS, Safari: FAIL)
Current times and effect phase at effect start when delay = 375 and endDelay = 375 |: FAIL (Chrome: PASS, Safari: FAIL)
Current times and effect phase in timeline range when delay = 375 and endDelay = 375 |: FAIL (Chrome: PASS, Safari: FAIL)
Current times and effect phase at effect end when delay = 375 and endDelay = 375 |: FAIL (Chrome: PASS, Safari: FAIL)
Current times and effect phase after effect endDelay when delay = 375 and endDelay = 375 |: FAIL (Chrome: PASS, Safari: FAIL)
Current times and effect phase at timeline end when delay = 375 and endDelay = 375 |: FAIL (Chrome: PASS, Safari: FAIL)
Current times and effect phase after timeline end when delay = 375 and endDelay = 375 |: FAIL (Chrome: PASS, Safari: FAIL)
Current times and effect phase before timeline start when delay = 600 and endDelay = -100 |: FAIL (Chrome: PASS, Safari: FAIL)
Current times and effect phase at timeline start when delay = 600 and endDelay = -100 |: FAIL (Chrome: PASS, Safari: FAIL)
Current times and effect phase before effect delay when delay = 600 and endDelay = -100 |: FAIL (Chrome: PASS, Safari: FAIL)
Current times and effect phase at effect start when delay = 600 and endDelay = -100 |: FAIL (Chrome: PASS, Safari: FAIL)
Current times and effect phase in timeline range when delay = 600 and endDelay = -100 |: FAIL (Chrome: PASS, Safari: FAIL)
Current times and effect phase at timeline end when delay = 600 and endDelay = -100 |: FAIL (Chrome: PASS, Safari: FAIL)
Current times and effect phase after timeline end when delay = 600 and endDelay = -100 |: FAIL (Chrome: PASS, Safari: FAIL)
Current times and effect phase before timeline start when delay = -100 and endDelay = 600 |: FAIL (Chrome: PASS, Safari: FAIL)
Current times and effect phase at timeline start when delay = -100 and endDelay = 600 |: FAIL (Chrome: PASS, Safari: FAIL)
Current times and effect phase in timeline range when delay = -100 and endDelay = 600 |: FAIL (Chrome: PASS, Safari: FAIL)
Current times and effect phase at effect end when delay = -100 and endDelay = 600 |: FAIL (Chrome: PASS, Safari: FAIL)
Current times and effect phase after effect endDelay when delay = -100 and endDelay = 600 |: FAIL (Chrome: PASS, Safari: FAIL)
Current times and effect phase at timeline end when delay = -100 and endDelay = 600 |: FAIL (Chrome: PASS, Safari: FAIL)
Current times and effect phase after timeline end when delay = -100 and endDelay = 600 |: FAIL (Chrome: PASS, Safari: FAIL)
Current times and effect phase before timeline start when delay = -200 and endDelay = -200 |: FAIL (Chrome: PASS, Safari: FAIL)
Current times and effect phase at timeline start when delay = -200 and endDelay = -200 |: FAIL (Chrome: PASS, Safari: FAIL)
Current times and effect phase in timeline range when delay = -200 and endDelay = -200 |: FAIL (Chrome: PASS, Safari: FAIL)
Current times and effect phase at timeline end when delay = -200 and endDelay = -200 |: FAIL (Chrome: PASS, Safari: FAIL)
Current times and effect phase after timeline end when delay = -200 and endDelay = -200 |: FAIL (Chrome: PASS, Safari: FAIL)
Verify that (play -> pause -> play) doesn't change phase/progress.: FAIL (Chrome: PASS, Safari: FAIL)
Pause in before phase, scroll timeline into active phase, animation should remain in the before phase: FAIL (Chrome: PASS, Safari: FAIL)
Make scroller inactive, then set current time to an in range time: FAIL (Chrome: PASS, Safari: FAIL)
Animation effect is still applied after pausing and making timeline inactive.: FAIL (Chrome: PASS, Safari: FAIL)
Tests Disabled in Gecko Infrastructure
/scroll-animations/scroll-animation-effect-phases.tentative.html: OK [GitHub], SKIP [Gecko-android-em-7.0-x86_64-lite-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-linux1804-64-tsan-qr-opt] (Chrome: OK, Safari: OK)
|
||
Comment 5•4 years ago
|
||
| bugherder | ||
Description
•