Closed Bug 1732058 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 30807 - Use interpolation at the endpoints of animations.

Categories

(Core :: Web Painting, task, P4)

Product:
Core
Component:
Web Painting
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
95 Branch
Tracking Flags:
Tracking Status
firefox95 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 30807 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/30807
Details from upstream follow.

L. David Baron <dbaron@chromium.org> wrote:

Use interpolation at the endpoints of animations.

Use interpolation at the endpoints of animations (by removing various
optimizations to return the endpoint values at the endpoints), since
it's needed to get the correct axis for animation of the 'rotate'
property, the correct conversion away from a 'none' value at one
endpoint for the 'rotate', 'scale', and 'translate' properties, and
correct list lengths for list-valued properties that can interpolate
between lists of mismatched lengths, whether by repeating to the least
common multiple length (stroke-dasharray) or filling the shorter list
with no-op or zero values (filter, backdrop-filter, box-shadow,
text-shadow, some registered custom properties).

The changes to translate-composition.html and scale-composition.html
cause Firefox to pass the tests whose expectations are being modified,
and thus, like Chrome, pass the entire file (whereas they cause Safari
to fail additional tests). The test changes are discussed further in
https://github.com/web-platform-tests/wpt/issues/30377 .

The differences between the test expectations for background-image
(where the test expects discrete animation, per the spec) and for
-webkit-mask-image (where the test expects -webkit-cross-fade()) is
rather suspicious, but I've left the difference as-is for now.

Fixed: 1026169, 1180834
Change-Id: I6320b74b0aff29989a748fab1bff78b91426701e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3139948
Reviewed-by: Kevin Ellis \<kevers@chromium.org>
Reviewed-by: Anders Hartvoll Ruud \<andruud@chromium.org>
Commit-Queue: David Baron \<dbaron@chromium.org>
Cr-Commit-Position: refs/heads/main@{#923427}

Component: web-platform-tests → Web Painting
Product: Testing → Core

CI Results

Ran 11 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 5 tests and 56 subtests

Status Summary

Firefox

OK : 5
PASS: 219
FAIL: 13

Chrome

OK : 5
PASS: 214
FAIL: 18

Safari

OK : 5
PASS: 75
FAIL: 157

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/css/css-transforms/animation/rotate-composition.html
Compositing: property <rotate> underlying [1 2 3 40deg] from add [2 4 6 10deg] to add [3 6 9 50deg] at (-1) should be [0.27 0.53 0.8 10deg]: FAIL (Chrome: PASS, Safari: FAIL)
Compositing: property <rotate> underlying [1 2 3 40deg] from add [2 4 6 10deg] to add [3 6 9 50deg] at (0.25) should be [0.27 0.53 0.8 60deg]: FAIL (Chrome: PASS, Safari: FAIL)
Compositing: property <rotate> underlying [1 2 3 40deg] from add [2 4 6 10deg] to add [3 6 9 50deg] at (0.75) should be [0.27 0.53 0.8 80deg]: FAIL (Chrome: PASS, Safari: FAIL)
Compositing: property <rotate> underlying [1 2 3 40deg] from add [2 4 6 10deg] to add [3 6 9 50deg] at (1) should be [0.27 0.53 0.8 90deg]: FAIL (Chrome: PASS, Safari: FAIL)
Compositing: property <rotate> underlying [1 2 3 40deg] from add [2 4 6 10deg] to add [3 6 9 50deg] at (2) should be [0.27 0.53 0.8 130deg]: FAIL (Chrome: PASS, Safari: FAIL)
Compositing: property <rotate> underlying [1 2 3 270deg] from add [1 2 3 90deg] to replace [0 1 0 100deg] at (0) should be [0.27 0.53 0.8 0deg]: FAIL (Chrome: FAIL, Safari: FAIL)
Compositing: property <rotate> underlying [1 2 3 270deg] from add [1 2 3 90deg] to replace [0 1 0 100deg] at (0.25) should be [y 25deg]: FAIL (Chrome: PASS, Safari: FAIL)
Compositing: property <rotate> underlying [1 2 3 270deg] from add [1 2 3 90deg] to replace [0 1 0 100deg] at (0.75) should be [y 75deg]: FAIL (Chrome: PASS, Safari: FAIL)
Compositing: property <rotate> underlying [1 2 3 270deg] from add [1 2 3 90deg] to replace [0 1 0 100deg] at (2) should be [y 200deg]: FAIL (Chrome: PASS, Safari: FAIL)
Compositing: property <rotate> underlying [1 2 3 90deg] from add [2 4 6 270deg] to replace [0 1 0 100deg] at (0) should be [0.27 0.53 0.8 0deg]: FAIL (Chrome: FAIL, Safari: FAIL)
Compositing: property <rotate> underlying [1 2 3 90deg] from add [2 4 6 270deg] to replace [0 1 0 100deg] at (0.25) should be [y 25deg]: FAIL (Chrome: PASS, Safari: FAIL)
Compositing: property <rotate> underlying [1 2 3 90deg] from add [2 4 6 270deg] to replace [0 1 0 100deg] at (0.75) should be [y 75deg]: FAIL (Chrome: PASS, Safari: FAIL)
Compositing: property <rotate> underlying [1 2 3 90deg] from add [2 4 6 270deg] to replace [0 1 0 100deg] at (2) should be [y 200deg]: FAIL (Chrome: PASS, Safari: FAIL)

Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/ca0fc4ff1763 [wpt PR 30807] - Use interpolation at the endpoints of animations., a=testonly https://hg.mozilla.org/integration/autoland/rev/cc93ca5e9e46 [wpt PR 30807] - Update wpt metadata, a=testonly
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/448eb0d376aa [wpt PR 30807] - Use interpolation at the endpoints of animations., a=testonly https://hg.mozilla.org/integration/autoland/rev/2b6a78545fbc [wpt PR 30807] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/448eb0d376aa
https://hg.mozilla.org/mozilla-central/rev/2b6a78545fbc

Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox95: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 95 Branch
You need to log in before you can comment on or make changes to this bug.