1732059 - [wpt-sync] Sync PR 30891 - Remove stashed request headers for speculative parser tests

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 30891 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/30891
Details from upstream follow.

Mason Freed <[e-mail]> wrote:

Remove stashed request headers for speculative parser tests

The old code would append all of the request headers for the request
to the stashed value. That causes the failure string for all dependent
tests to change when, e.g. the User-Agent string changes due to the
test being run on a different bot.

This CL removes the headers, as those seem only useful for debugging,
and are causing lots of flaky behavior on at least Chromium bots.

Prior failure message:
FAIL Speculative parsing, document.write(): link-rel-stylesheet-disabled Unhandled rejection: assert_equals: speculative case incorrectly fetched expected "" but got "param-encodingcheck: %C4%9E\r\nHost: web-platform.test:8001\nConnection: keep-alive\nUser-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/999.77.34.5 Safari/537.36\nAccept: text/css,/;q=0.1\nReferer: http://web-platform.test:8001/html/syntax/speculative-parsing/generated/document-write/link-rel-stylesheet-disabled.tentative.sub.html\nAccept-Encoding: gzip, deflate\nAccept-Language: en-us,en\n\n"

New failure message:
FAIL Speculative parsing, document.write(): link-rel-stylesheet-disabled Unhandled rejection: assert_equals: speculative case incorrectly fetched expected "" but got "param-encodingcheck: %C4%9E\r\n"

Fixed: 1250457,1249920,1249921,1249954,1250003,1250004
Bug: 1144176
Change-Id: I45dbbb8794c6bf2d5e962cecf531e06a7af09160
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3170927
Commit-Queue: Mason Freed \<[e-mail]>
Auto-Submit: Mason Freed \<[e-mail]>
Reviewed-by: Joey Arhar \<[e-mail]>
Cr-Commit-Position: refs/heads/main@{#923491}

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

PR 30891 applied with additional changes from upstream: 9afacb73a04c1f33837eb0a7ffcd9ec16c9d477f

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=cb697b53acc8e7c35396a90a3a07d8686e047f87

Comment 3

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 7 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 53 tests and 1 subtests

Status Summary

Firefox

OK : 53
PASS: 49
FAIL: 4

Chrome

OK : 53
PASS: 39
FAIL: 14

Safari

OK : 53
PASS: 36
FAIL: 17

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

Firefox-only Failures

/html/syntax/speculative-parsing/generated/document-write/link-rel-stylesheet-unsupported-type.tentative.sub.html
Speculative parsing, document.write(): link-rel-stylesheet-unsupported-type: FAIL

New Tests That Don't Pass

/html/syntax/speculative-parsing/generated/document-write/link-rel-stylesheet-disabled.tentative.sub.html
Speculative parsing, document.write(): link-rel-stylesheet-disabled: FAIL (Chrome: FAIL, Safari: FAIL)
/html/syntax/speculative-parsing/generated/document-write/link-rel-stylesheet-nomatch-media.tentative.sub.html
Speculative parsing, document.write(): link-rel-stylesheet-nomatch-media: FAIL (Chrome: FAIL, Safari: FAIL)
/html/syntax/speculative-parsing/generated/document-write/link-rel-stylesheet-unsupported-type.tentative.sub.html
Speculative parsing, document.write(): link-rel-stylesheet-unsupported-type: FAIL (Chrome: PASS, Safari: PASS)
/html/syntax/speculative-parsing/generated/document-write/meta-viewport-link-stylesheet-media.tentative.sub.html
Speculative parsing, document.write(): meta-viewport-link-stylesheet-media: FAIL (Chrome: FAIL, Safari: FAIL)

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/214c5b0c273e
[wpt PR 30891] - Remove stashed request headers for speculative parser tests, a=testonly

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bb95073a1cfa
[wpt PR 30891] - Remove stashed request headers for speculative parser tests, a=testonly

Comment 6

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/bb95073a1cfa