Closed Bug 1732060 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 30876 - Don't include BR clearance in the line's height.

Categories

(Core :: Layout: Ruby, task, P4)

Product:
Core
Component:
Layout: Ruby
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
95 Branch
Tracking Flags:
Tracking Status
firefox95 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 30876 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/30876
Details from upstream follow.

Morten Stenshorne <mstensho@chromium.org> wrote:

Don't include BR clearance in the line's height.

Including clearance in the line height may result in tall monolithic
content, which is problematic for block fragmentation, especially for
column balancing.

Instead, store trailing clearance in the layout result, so that the
block layout algorithm can add it to the layout position for subsequent
content.

We already use a similar trick for ruby annotations, and some care is
required so that we don't move back above the clearance offset when
canceling ruby annotations overflow (which happens in some cases). There
was no test coverage for this, so added three tests for that (they pass
both and without this CL).

Also added a multicol test that demonstrates what this fixes in column
balancing.

Bug: 829028
Change-Id: I84e58326e9ada78e3f29ad01d8043a173626aea3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3168645
Commit-Queue: Morten Stenshorne \<mstensho@chromium.org>
Reviewed-by: Ian Kilpatrick \<ikilpatrick@chromium.org>
Reviewed-by: Koji Ishii \<kojii@chromium.org>
Cr-Commit-Position: refs/heads/main@{#923502}

Component: web-platform-tests → Layout: Ruby
Product: Testing → Core
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ce5f03f5d53e
[wpt PR 30876] - Don't include BR clearance in the line's height., a=testonly
https://hg.mozilla.org/integration/autoland/rev/698d10acdee3
[wpt PR 30876] - Update wpt metadata, a=testonly
Test result changes from PR not available.
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/5e0036233023
[wpt PR 30876] - Don't include BR clearance in the line's height., a=testonly
https://hg.mozilla.org/integration/autoland/rev/ee7f6f12c858
[wpt PR 30876] - Update wpt metadata, a=testonly
Test result changes from PR not available.

https://hg.mozilla.org/mozilla-central/rev/5e0036233023
https://hg.mozilla.org/mozilla-central/rev/ee7f6f12c858

Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox95: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 95 Branch
You need to log in before you can comment on or make changes to this bug.