Closed Bug 1732082 Opened 3 years ago Closed 2 years ago

Enable layout.css.grid-item-baxis-measurement.enabled for all channels

Categories

(Core :: Layout: Grid, enhancement)

enhancement

Tracking

()

VERIFIED FIXED
100 Branch
Performance Impact low
Tracking Status
firefox100 --- verified

People

(Reporter: sefeng, Assigned: sefeng)

References

(Depends on 1 open bug)

Details

(Keywords: perf:responsiveness)

Attachments

(1 file)

layout.css.grid-item-baxis-measurement.enabled is default on for Nightly. Eventually, we'd want to have it enabled everywhere.

I'm adding bug 1682686 as a dependency. It probably isn't a hard blocker for shipping this, but ideally I'd like for us to at least understand why this pref only gives us a ~2x speedup in the nested-grid testcases there (rather than removing the exponential-cost behavior entirely, as I would expect if we were fully benefiting from this caching).

It seems possible there's just an incremental improvement that we need in order for that bug's testcases to fully benefit from this optimization.

No longer blocks: 1591366
Depends on: 1682686, 1591366
Depends on: 1735376
Depends on: 1735931
Whiteboard: [qf]
Whiteboard: [qf] → [qf:p3:responsiveness]
Depends on: 1746228
Depends on: 1757025
Performance Impact: --- → P3
Whiteboard: [qf:p3:responsiveness]
Assignee: nobody → sefeng
Status: NEW → ASSIGNED
Pushed by sefeng@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c6867118d012
Enable layout.css.grid-item-baxis-measurement.enabled in all channels r=dholbert
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 100 Branch
QA Whiteboard: [qa-100b-p2]

This enhancement was verified on macOS 11, Win10-64 bits and Ubuntu 20.04. layout.css.grid-item-baxis-measurement.enabled is now set by default on true on Firefox 100.0.

Status: RESOLVED → VERIFIED
QA Whiteboard: [qa-100b-p2]
You need to log in before you can comment on or make changes to this bug.