1732120 - Rename BrowsingContextTargetActor WindowGlobalTargetActor

Status: RESOLVED FIXED

(DevTools :: General, task)

Description

[Alexandre Poirot [:ochameau]]

Since we enable server side targets, all BrowsingContextTargetActor are actually rather WindowGlobalTargetActor as they all follow the lifecycle of the WindowGlobal.

So that it would be cleared if we rename this class as well as anything refering to this particular target (front, typeName, spec,...)

Comment 1

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1732120 - [devtools] Rename BrowsingContextTargetActor to WindowGlobalTargetActor.

Comment 2

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1732120 - [devtools] Remove FrameTargetActor in favor of WindowGlobalTargetActor.

This intermediate actor is no longer useful for a while.
(Since we dropped the LocalTabProxy. I think since we introduced the TabDescriptor?)

I updated actor-hierarchy.md significantly as it was quite outdated!
We would probably benefit having a section dedicated to the WatcherActor.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/23fa337d8f5a
[devtools] Rename BrowsingContextTargetActor to WindowGlobalTargetActor. r=nchevobbe,devtools-backward-compat-reviewers
https://hg.mozilla.org/integration/autoland/rev/1f92bcc65877
[devtools] Remove FrameTargetActor in favor of WindowGlobalTargetActor. r=nchevobbe,devtools-backward-compat-reviewers

Comment 4

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/23fa337d8f5a
https://hg.mozilla.org/mozilla-central/rev/1f92bcc65877