Closed Bug 1732263 Opened 4 years ago Closed 1 year ago

Enable BFCacheInParent for CDP with Fission enabled

Categories

(Remote Protocol :: CDP, task, P3)

Product:
Remote Protocol
Component:
CDP
Type:
task
Points:
13

Tracking

(Not tracked)

Status:
RESOLVED WONTFIX

People

(Reporter: whimboo, Unassigned)

References

Details

To get Fission enabled for CDP we will have to disable BFCacheInParent for the moment. See bug 1601245. But as mentioned by Nika this should be a short-term workaround, and we are better doing in re-enabling it as soon as possible.

Maybe the work on bug 1706353 would be enough to get us support. It would need to be further investigated.

Fission Milestone: --- → Future
Points: --- → 13
Priority: -- → P3

I wonder why we can't just leave bfcache disabled indefinitely for CDP. I don't think we want to support CDP for longer than it takes to replace the functionality with BiDi. Since bfcache is mostly an optimisation, it seems plausibly reasonable to just disable it for webapp testing and accept the risk of Puppeteer users missing some issue with their site that only happens with bfcache enabled.

We can only keep it disabled as long as the preference fission.bfcacheInParent exists, and allows us to opt-out from having BFCache in the parent process. When it will be removed we won't have a choice. But again this is P3 and can be delayed as long as we do not get an indication of the preference removal.

The severity field is not set for this bug.
:whimboo, could you have a look please?

For more information, please visit auto_nag documentation.

Flags: needinfo?(hskupin)

This should actually be a task and not a defect.

Type: defect → task
Flags: needinfo?(hskupin)
Fission Milestone: Future → ---
Whiteboard: [bidi-m2-mvp]
Duplicate of this bug: 1805935
Blocks: 1776290
Summary: Enable BFCacheInParent for CDP with Fission enabled → Enable BFCacheInParent (SHIP - Session History in Parent) for CDP

When I investigated the issue again I noticed that there are actually two different preferences here. These are fission.bfcacheInParent and fission.sessionHistoryInParent. In our case we only disable the first one, which is not SHIP!

After talking to Olli about both preferences he mentioned that the ongoing SHIP work will not affect the BFCache setting. As such we shouldn't worry about fission.bfcacheInParent for now and that this pref might actually never get removed.

No longer blocks: 1776290
Summary: Enable BFCacheInParent (SHIP - Session History in Parent) for CDP → Enable BFCacheInParent for CDP with Fission enabled

CDP is deprecated and we no longer actively work on this protocol. As such lets close out this bug.

Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.