1732356 - Tidy up WasmIonCompile in preparation for memory64

Status: RESOLVED FIXED

(Core :: JavaScript: WebAssembly, enhancement, P3)

Description

[Lars T Hansen [:lth]]

We should reorg very slightly and comment somewhat copiously around heap access in WasmIonCompile to set us up for sanely changing things for memory64. Right now the logic for bounds and alignment check optimization is very tangled and in general there is little documentation about this.

Comment 1

[Lars T Hansen [:lth]]

Attachment: Bug 1732356 - Bounds checking comments + some ion cleanup. r?rhunt

Move SIMD memory access implementations into a "memory access" part of
WasmIonCompile, to keep all memory access operations together.

Factor WasmIonCompile memory access logic to make it clearer, and
comment.

Document the heap structure + bounds checking logic generally. (A
very small amount of documentation pertains to memory64, I judged that
this was probably OK. More documentation will be added when memory64
lands.)

No functional changes whatsoever are intended.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f1923637734f
Bounds checking comments + some ion cleanup. r=rhunt

Comment 3

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/f1923637734f

Comment 4

[Lars T Hansen [:lth]]

Attachment: Bug 1732356 - Document some memory functions better. r?yury

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/64afb5141f63
Document some memory functions better.  r=yury

Comment 6

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/64afb5141f63