1732664 - Crash in [@ mozilla::dom::ScriptLoader::ResolveImportedModule]

Status: RESOLVED DUPLICATE of bug 1751313

(Core :: DOM: Core & HTML, defect)

Description

[Gabriele Svelto [:gsvelto] (PTO)]

Maybe Fission related. (DOMFissionEnabled=1)

Crash report: https://crash-stats.mozilla.org/report/index/5a203ca7-7f25-45de-a037-339fe0210924

Reason: EXCEPTION_ACCESS_VIOLATION_READ

Top 10 frames of crashing thread:

0 xul.dll static mozilla::dom::ScriptLoader::ResolveImportedModule dom/script/ScriptLoader.cpp:1091
1 xul.dll mozilla::dom::HostResolveImportedModule dom/script/ScriptLoader.cpp:1041
2 xul.dll js::CallModuleResolveHook js/src/builtin/ModuleObject.cpp:2076
3 xul.dll intrinsic_HostResolveImportedModule js/src/vm/SelfHosting.cpp:1758
4 xul.dll js::InternalCallOrConstruct js/src/vm/Interpreter.cpp:472
5 xul.dll Interpret js/src/vm/Interpreter.cpp:3239
6 xul.dll js::InternalCallOrConstruct js/src/vm/Interpreter.cpp:504
7 xul.dll js::Call js/src/vm/Interpreter.cpp:549
8 xul.dll js::CallSelfHostedFunction js/src/vm/SelfHosting.cpp:1538
9 xul.dll InvokeSelfHostedMethod js/src/builtin/ModuleObject.cpp:1308

At first I thought that this was a random crash but upon further inspection it looks like it might be a real issue:

• It's a NULL pointer dereference, we're trying to access a field of an object specifically
• The stack is consistent across crashes
• It happens on all platforms
• The offset is consistent across 64-bit and 32-bit builds (that is, it's smaller in 32-bit builds but what you would expect it to be)

The comments and URLs in the crash aren't very helpful except maybe for this one:

Tried to import an ES6 module that was being served as text/html.

NI?ing myself to crack open a minidump and see if I can divine some further information from it.

Comment 1

[Gabriele Svelto [:gsvelto] (PTO)]

I couldn't divine much from the minidump except that global is NULL and loader->GetFetchedModule() is apparently returning NULL too.

Comment 2

[Hsin-Yi Tsai (she/her) [:hsinyi]]

Hi Jon,
We're reviewing old S2 bugs.
There's no ResolveImportedModule in ScriptLoader.cpp. And you rewrote the shell module loader so we think you may be the right person to take a look at this, and assess if this is still S2.

Comment 3

[Jon Coppeard (:jonco)]

(In reply to Hsin-Yi Tsai [:hsinyi] from comment #2)

There's no ResolveImportedModule in ScriptLoader.cpp.

This was removed as part of recfactoring in bug 1311726.