1732783 - Opened event view forces Edit button beyond window border when a text string above flows to a second line

Status: VERIFIED FIXED

(Calendar :: Dialogs, defect)

Description

[Dave Labrecque]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/93.0.4577.82 Safari/537.36

Steps to reproduce:

Create an event with a long-enough text string in the title or location fields
Open the event

Actual results:

Opened event's Edit button is forced over the bottom window border if a text string in the above fields has more than one line of text. This effect can be toggled by dragging the right border to toggle the number of lines for the affecting text string.

Expected results:

Window should have reformatted to allow space around the Edit button.

Admittedly it's not a huge issue. But it does seem not right.

Comment 1

[Dave Labrecque]

Should have said that it's text strings in the fields above the Description box that are important. I think only Title or Location fields are capable of such long strings.

Comment 2

[Dave Labrecque]

Attachment: Event view bug.PNG

Comment 3

[Geoff Lankow (:darktrojan)]

This has been annoying me for ages.

Comment 4

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1732783 - Resize calendar item summary dialog to match contents. r=mkmelin

If a line of text wraps, the content doesn't fit any more and the edit button falls off the bottom.

Depends on D127598

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/db98a16886d1
Resize calendar item summary dialog to match contents. r=mkmelin

Comment 6

[Geoff Lankow (:darktrojan)]

Comment on attachment 9244442 [details]
Bug 1732783 - Resize calendar item summary dialog to match contents. r=mkmelin

[Approval Request Comment]
Regression caused by (bug #):
User impact if declined: calendar event summary window is too small
Testing completed (on c-c, etc.): in 94
Risk to taking this patch (and alternatives if risky): none

Comment 7

[Geoff Lankow (:darktrojan)]

Comment on attachment 9244442 [details]
Bug 1732783 - Resize calendar item summary dialog to match contents. r=mkmelin

Oops, wrong flag.

[Approval Request Comment]
Regression caused by (bug #):
User impact if declined: calendar event summary window is too small
Testing completed (on c-c, etc.): landed a week ago
Risk to taking this patch (and alternatives if risky): none

Comment 8

[Wayne Mery (:wsmwk)]

Comment on attachment 9244442 [details]
Bug 1732783 - Resize calendar item summary dialog to match contents. r=mkmelin

[Triage Comment]
Approved for beta

Comment 9

[Rob Lemley [:rjl]]

Thunderbird 94.0b3:
https://hg.mozilla.org/releases/comm-beta/rev/f9546cc220e1

Comment 10

[WaltS48 [:walts48]]

Verified using 94.0b3 on Windows 10.

Comment 11

[Geoff Lankow (:darktrojan)]

Comment on attachment 9244442 [details]
Bug 1732783 - Resize calendar item summary dialog to match contents. r=mkmelin

[Approval Request Comment]
Regression caused by (bug #):
User impact if declined: calendar event summary window is too small
Testing completed (on c-c, etc.): in 94b3
Risk to taking this patch (and alternatives if risky): none

Comment 12

[Wayne Mery (:wsmwk)]

Comment on attachment 9244442 [details]
Bug 1732783 - Resize calendar item summary dialog to match contents. r=mkmelin

[Triage Comment]
Approved for esr91

Comment 13

[Rob Lemley [:rjl]]

Thunderbird 91.3.0:
https://hg.mozilla.org/releases/comm-esr91/rev/95609692af26

Comment 14

[Dave Labrecque]

Nice. Cool. However...

The button still goes a bit off-window when drag-minimizing the window size. Should I open a new bug for that?