1732795 - Bump pytest version

Status: RESOLVED FIXED

(Testing :: Python Test, enhancement)

Description

[Mitchell Hentges [:mhentges] 🦀]

Our pytest==4.6.6 is almost three years old.
Newer versions have new features/APIs, slightly better performance, and a cool "warnings" display that makes failures caused by misuse easier to spot.

Comment 1

[Mitchell Hentges [:mhentges] 🦀]

Attachment: WIP: Bug 1732795: Bump attrs to be compatible with new pytest

A bunch of modern packages (pytest, twisted, automat) all need attrs==19.2.0 (or newer).
We could bump attrs all the way to the modern 21.4.0 version, but I'd like to defer that upgrade risk, since there's a
lot of backwards-incompatible changes and deprecations. So, lightly bump it to 19.2.0.

Comment 2

[Phabricator Automation]

Comment on attachment 9257964 [details]
WIP: Bug 1732795: Bump attrs to be compatible with new pytest

Revision D135178 was moved to bug 1748737. Setting attachment 9257964 [details] to obsolete.

Comment 3

[Mitchell Hentges [:mhentges] 🦀]

Attachment: Bug 1732795: Resolve upcoming pytest deprecations

Following the pytest "deprecations and removals" docs [1], this patch:

• Replaces @pytest.yield_fixture with @pytest.fixture.
• Replaces .funcargnames with .fixturenames.
• Uses Pathlib parameter instead of the py.path.local one in
  associated pytest_* hooks.
• Replaces --strict with --strict-markers

[1] https://docs.pytest.org/en/latest/deprecations.html

Depends on D138608

Comment 4

[Mitchell Hentges [:mhentges] 🦀]

Attachment: Bug 1732795: Install `coverage` using pip

coverage has native code, so the vendored version was only used as
source code from which the actual package could be built.
Since its always used in a context where we can pip install over the
network, let's do that. This cleans up our tree a bit and allows us to
leverage the coverage wheels.

Depends on D138815

Comment 5

[Mitchell Hentges [:mhentges] 🦀]

Attachment: Bug 1732795: [WILL-SQUASH] Unvendor `coverage`

Depends on D138816

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d0f3bf6ad3a3
Resolve upcoming pytest deprecations r=webdriver-reviewers,ahal,whimboo
https://hg.mozilla.org/integration/autoland/rev/0bfaaa811421
Install `coverage` using pip r=ahal

Comment 7

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/32902 for changes under testing/web-platform/tests

Comment 8

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/d0f3bf6ad3a3
https://hg.mozilla.org/mozilla-central/rev/0bfaaa811421

Comment 9

[Mitchell Hentges [:mhentges] 🦀]

Attachment: Bug 1732795: Update pytest to 7.0.1

3.6.2 was 3 years old. There's been many helpful features and
ergonomics improvements in the years since.

Depends on D140258

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/72f8fcf776c9
Update pytest to 7.0.1 r=ahal

Comment 11

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/72f8fcf776c9

Comment 12

[Mathew Hodson]

Can this be closed now?

Comment 13

[Mitchell Hentges [:mhentges] 🦀]

Good call, yep!

Comment 14

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR was closed without merging

Comment 15

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot