Closed Bug 1732928 Opened 3 years ago Closed 3 years ago

Migrate an existing geckoview-streaming metric to native Glean

Categories

(Toolkit :: Telemetry, task, P1)

task

Tracking

()

RESOLVED FIXED
95 Branch
Tracking Status
firefox95 --- fixed

People

(Reporter: janerik, Assigned: janerik)

References

Details

Attachments

(1 file)

With Glean enabled in GeckoView and metric types usable, we need a first test case to ensure it works.
We already transport some metrics from Gecko to Fenix using GeckoView Streaming (aka Project EXTRACT), so we can pick one of those for migration.

I think to start we might wish to "migrate" one while still leaving the Telemetry in place until after verification. In other words:

  1. Add a new Glean collection that mimics the EXTRACT'd collection
  2. Verify that they report similar/identical data (modulo timing and representation differences)
  3. Remove the mimic, properly migrate the EXTRACT'd collection

(( And all this maintaining the flow of data to Telemetry (ie, step 3 involves setting up GIFFT) ))

With Glean enabled on Android we can move metrics from Geckoview Streaming1
into proper native Glean metrics.
The metrics keep their name and thus no change should be noticable,
except native use of FOG/Glean inside Gecko

Depends on D126800

(In reply to Chris H-C :chutten from comment #1)

I think to start we might wish to "migrate" one while still leaving the Telemetry in place until after verification. In other words:

  1. Add a new Glean collection that mimics the EXTRACT'd collection
  2. Verify that they report similar/identical data (modulo timing and representation differences)
  3. Remove the mimic, properly migrate the EXTRACT'd collection

(( And all this maintaining the flow of data to Telemetry (ie, step 3 involves setting up GIFFT) ))

Yes, we can also go that way. fwiw I still posted the patch as is for now to proof it "works" as in it compiles and I see some data in a first test run.
Your staged approach will let us verify that in the real world first, so I'm not opposed to changing it to that.

Re step 3: No need! geckoview.version and .build_id are legacy telemetry probes for the sole purpose of being EXTRACTed. They don't appear in legacy telemetry at all.

Attachment #9243244 - Attachment description: Bug 1732928 - Migrate gecko.{version, build_id} metrics from EXTRACT to native Glean. r?chutten!,jrmuizel! → Bug 1732928 - Mirror gecko.{version, build_id} metrics from EXTRACT to native Glean. r?chutten!,jrmuizel!
Pushed by jrediger@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/a08d38312b7f Mirror gecko.{version, build_id} metrics from EXTRACT to native Glean. r=chutten,jrmuizel
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 95 Branch
Regressions: 1749394
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: