1733085 - Send fails for some SMTP servers in TB 91 with new mailnews.smtp.jsmodule

Status: RESOLVED FIXED

(MailNews Core :: Networking: SMTP, defect)

Description

[anguel.stankov]

Attachment: TB91_two_smtp_logfiles.txt

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/94.0.4606.61 Safari/537.36

Steps to reproduce:

After upgrading to TB 91 (Win 10, latest TB is now 91.1.2 (32-Bit)) there are serious problems sending emails via two SMTP servers:

1. Hornetsecurity (smtp.antispameurope.com)

2. Our domain-internal Mailstore Gateway SMTP (mailstore.mycompany.local)

Both failing SMTP servers use STARTTLS with normal password.

Actual results:

NOTE: BOTH LOGFILES ARE ATTACHED

1. Hornetsecurity (smtp.antispameurope.com)
   Here a password prompt dialog appears again and again although the password is already saved and correct. Strangely the email is sent nevertheless.

2. Our domain-internal Mailstore Gateway SMTP (mailstore.mycompany.local)
   Here the sending dialog simply hangs (and flickers a little) until cancel is selected. The email is not sent.

In contrast: When "mailnews.smtp.jsmodule" is set to "false" everything works as expected. So the problem seems to be related to the new SMTP module in TB 91.

Also, the problem does not exist with the Domainfactory SMTP server (sslout.df.eu).

The problem can be reproduced on all PCs. Turning off Kaspersky Security or starting TB in safe mode does not help.

Expected results:

Email should be sent normally.

Comment 1

[Ping Chen [:rnons] (away)]

Attachment: Bug 1733085 - Remove unneeded timeout handling in SmtpClient.jsm. r=mkmelin

Also encode username when constructing server uri for auth.

Comment 2

[Ping Chen [:rnons] (away)]

Hi, can you help me test by downloading an artifact build from https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/PnLu4CQGT9KiJPDwGHzZ2w/runs/0/artifacts/public/build/target.zip? It's built by https://treeherder.mozilla.org/jobs?repo=try-comm-central&revision=55c2d4cb823c3f6553946a2bf3755c89f03e5b89.

If the second problem is not fixed, please tell me if you have some special characters in your SMTP username. Thanks.

Comment 3

[anguel.stankov]

Thank you very much. Sorry I was very busy today, will test ASAP tomorrow.
Regarding username, yes Mailstore Gateway works by setting the target SMTP server and the local mailbox in the SMTP User Name like this:
john.doe%smtp.example.net%mbx-dead1234beefdead5678beef
From: https://help.mailstore.com/en/server/Archiving_Emails_Without_Your_Own_Emailserver

Comment 4

[anguel.stankov]

I confirm that everything works fine now. Thank you so much, Ping Chen!

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/7e3e90dbd7d5
Remove unneeded timeout handling in SmtpClient.jsm. r=mkmelin

Comment 6

[Ping Chen [:rnons] (away)]

Comment on attachment 9243646 [details]
Bug 1733085 - Remove unneeded timeout handling in SmtpClient.jsm. r=mkmelin

[Approval Request Comment]
Regression caused by (bug #): bug 1661694
User impact if declined: Sometimes sending succeeded but got a false timeout error. Also if SMTP username contains %, auth may not work
Testing completed (on c-c, etc.): beta
Risk to taking this patch (and alternatives if risky): low

Comment 7

[Wayne Mery (:wsmwk)]

Comment on attachment 9243646 [details]
Bug 1733085 - Remove unneeded timeout handling in SmtpClient.jsm. r=mkmelin

[Triage Comment]
Approved for esr91

Comment 8

[Rob Lemley [:rjl]]

Thunderbird 91.2.1:
https://hg.mozilla.org/releases/comm-esr91/rev/f536036a6110