1733089 - NetMonitor - Disable cache text not properly centered - vertically

Status: VERIFIED FIXED

(DevTools :: Netmonitor, defect, P3)

Description

[Cristian Fogel [:cfogel]]

Attachment: disC.png

Affected versions

• 94.0a1( 20210928213647), 93.0

Affected platforms

• Win10

Steps to reproduce

1. Launch Firefox, open DevTools, Netmonitor tab;
2. Observe the Disable Cache button;

Expected result

• button and text are centered;

Actual result

• text has same baseline as button, not centered in available container;

Regression range

• not a regression, just that with the Proton rework it became more visible;

Additional notes

• on Dark theme it's really visible with the big border on the checkbox;
• attached screenshot to illustrate the issue.

Comment 1

[Hubert Boma Manilla (:bomsy)]

Thanks i can reproduce this.

Should likely be a small CSS change.

The element is found here
https://searchfox.org/mozilla-central/rev/7e36862b61622889b28492d60564dbab1e6d8bbf/devtools/client/netmonitor/src/components/Toolbar.js#422-436

The CSS is maybe located here
https://searchfox.org/mozilla-central/rev/7e36862b61622889b28492d60564dbab1e6d8bbf/devtools/client/netmonitor/src/assets/styles/Toolbar.css#69-83

Thanks

Comment 2

[Angelina]

Hello, can I work on this bug? (In reply to Hubert Boma Manilla (:bomsy) from comment #1)

Comment 3

[Hubert Boma Manilla (:bomsy)]

Sure Assigned to you.

Thanks

Comment 4

[Angelina]

Attachment: Bug 1733089 Minor css changes to vertically center items r?bomsy

Comment 5

[Angelina]

Attachment: Bug 1733089 disable cashe vertically centered r?bomsy

Depends on D128114

Comment 6

[Angelina]

Attachment: Bug 1733089 Minor css changes to vertically center items r?bomsy

Depends on D128114

Comment 7

[Angelina]

Attachment: Bug 1733089 Minor css changes to vertically center items r?bomsy

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a7bcad4139a5
Minor css changes to vertically center items r=Honza

Comment 9

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/a7bcad4139a5

Comment 10

[Simona Badau, Desktop QA]

Reproduced on Windows 10 x 64 using Firefox 94.0.1.
Verified as fixed on the latest Nightly 96.0a1 and Firefox 95 beta 3 - "Disable cache" text is now properly centered.